From: Eli Zaretskii <eliz@gnu.org>
To: Sebastian Sturm <s.sturm@arkona-technologies.de>
Cc: emacs-devel@gnu.org
Subject: Re: State of the overlay tree branch?
Date: Mon, 19 Mar 2018 14:57:52 +0200 [thread overview]
Message-ID: <83efkgnrxr.fsf@gnu.org> (raw)
In-Reply-To: <f3216876-e29c-a163-bd7e-102574a28ff7@arkona-technologies.de> (message from Sebastian Sturm on Mon, 19 Mar 2018 10:53:52 +0100)
> From: Sebastian Sturm <s.sturm@arkona-technologies.de>
> Date: Mon, 19 Mar 2018 10:53:52 +0100
>
> On 03/19/2018 07:43 AM, Eli Zaretskii wrote:
> >> From: Sebastian Sturm <s.sturm@arkona-technologies.de>
> >> Date: Mon, 19 Mar 2018 00:20:13 +0100
> >>
> >> for the record, I just switched back to emacs master (no noverlay) and
> >> the time reported by (benchmark-run 1000 (line-number-at-pos (point))
> >> increased by a factor of ~40, to 75-80s. At this level, editing is
> >> unbearably slow. With the semantic highlighter disabled, the same
> >> measurement yields ~2.5s (still painfully slow, but borderline usable),
> >> so about the same time reported by the noverlay branch.
> >
> > You will have to explain why overlays and the semantic highlighter
> > affect line-counting. How about presenting a profile produced by
> > "M-x profiler-report"?
>
> please find below a profiler report taken this morning (on my PC at
> work, which doesn't suffer from the performance issue as much as my 2014
> MacBook Pro, but even here the issue is clearly noticeable)
That profile says that self-insert-command takes a large percentage of
the time. So I think we should look into the reasons for such a
strange place to spend hundreds of microseconds. According to the
profile, line-number-at-pos takes about the same percentage of time as
self-insert-command does. And that is even before you optimize the
successive calls to line-counting code to take advantage of the
previously computed value for some close line.
> > And the timings you measure are 2.5 _milliseconds_ (the benchmark runs
> > 1000 times), right? If so, I cannot understand why you say that's
> > borderline usable, because IME such short times are imperceptible by
> > humans. I guess some other factor is at work here, so I'd suggest to
> > describe more details about your use case.
>
> well no, it's about 2.5ms per call to line-number-at-pos, which is
> called at least 6 times per character insertion (with my Emacs config,
> at least). Which already makes for 15ms per character insertion,
> excluding anything else done by cc-mode or lsp-mode.
Then, as I said, I don't understand why it takes so much on your
system. I get times that are 10 times faster.
next prev parent reply other threads:[~2018-03-19 12:57 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 20:14 State of the overlay tree branch? Sebastian Sturm
2018-03-18 20:39 ` Eli Zaretskii
2018-03-18 21:04 ` Sebastian Sturm
2018-03-18 23:03 ` Sebastian Sturm
2018-03-18 23:20 ` Sebastian Sturm
2018-03-19 6:43 ` Eli Zaretskii
2018-03-19 9:53 ` Sebastian Sturm
2018-03-19 12:57 ` Eli Zaretskii [this message]
2018-03-19 14:56 ` Stefan Monnier
2018-03-19 15:07 ` Sebastian Sturm
2018-03-19 15:13 ` Stefan Monnier
2018-03-20 1:23 ` Sebastian Sturm
2018-03-20 6:30 ` Eli Zaretskii
2018-03-21 0:36 ` Sebastian Sturm
2018-03-21 6:47 ` Eli Zaretskii
2018-03-22 13:16 ` Stefan Monnier
2018-03-22 19:54 ` Sebastian Sturm
2018-03-22 20:04 ` Sebastian Sturm
2018-03-22 20:52 ` Stefan Monnier
2018-03-22 23:11 ` Sebastian Sturm
2018-03-23 5:03 ` Stefan Monnier
2018-03-23 12:25 ` Sebastian Sturm
2018-03-23 12:47 ` Eli Zaretskii
2018-03-23 13:19 ` Stefan Monnier
2018-03-23 13:37 ` Noam Postavsky
2018-03-23 13:55 ` Stefan Monnier
2018-03-23 14:22 ` Eli Zaretskii
2018-03-23 14:39 ` Stefan Monnier
2018-03-23 19:39 ` Stefan Monnier
2018-03-25 15:11 ` Stefan Monnier
2018-03-25 16:39 ` Eli Zaretskii
2018-03-25 17:35 ` Stefan Monnier
2018-03-23 8:07 ` Eli Zaretskii
2018-03-23 9:08 ` Eli Zaretskii
2018-03-23 10:15 ` Sebastian Sturm
2018-03-23 12:39 ` Eli Zaretskii
2018-03-23 12:12 ` Stefan Monnier
2018-03-23 12:40 ` Eli Zaretskii
2018-03-23 12:55 ` Stefan Monnier
2018-03-19 6:36 ` Eli Zaretskii
2018-03-19 6:28 ` Eli Zaretskii
2018-03-21 14:14 ` Sebastien Chapuis
2018-03-21 15:35 ` Eli Zaretskii
2018-03-26 13:06 ` Stefan Monnier
2018-03-27 20:59 ` Sebastian Sturm
[not found] <<c24f8534-5245-026e-da18-f6be7b9702bf@arkona-technologies.de>
[not found] ` <<834lldp18f.fsf@gnu.org>
2018-03-18 21:37 ` Drew Adams
2018-03-19 1:33 ` Stefan Monnier
2018-03-19 6:50 ` Eli Zaretskii
2018-03-19 12:29 ` Stefan Monnier
2018-03-19 13:02 ` Eli Zaretskii
2018-03-19 13:43 ` Stefan Monnier
2018-03-19 14:28 ` Eli Zaretskii
2018-03-19 14:39 ` Stefan Monnier
2018-03-19 6:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83efkgnrxr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=s.sturm@arkona-technologies.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.