From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: State of the overlay tree branch? Date: Wed, 21 Mar 2018 08:47:18 +0200 Message-ID: <83efkekjrd.fsf@gnu.org> References: <834lldp18f.fsf@gnu.org> <9646341d-700b-4240-216b-8c0e753fa79f@arkona-technologies.de> <86d03e78-9984-f33e-a3f3-3faa4b34d78b@arkona-technologies.de> <83vadso9ad.fsf@gnu.org> <5155d5e2-6b5c-581e-89fe-4f3af717304f@arkona-technologies.de> <4c82fcbd-961a-c6ca-b1f0-6b85665cb339@arkona-technologies.de> <83po3zmf6o.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521614760 23183 195.159.176.226 (21 Mar 2018 06:46:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Mar 2018 06:46:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Sebastian Sturm Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 21 07:45:55 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyXVT-0005wQ-AI for ged-emacs-devel@m.gmane.org; Wed, 21 Mar 2018 07:45:55 +0100 Original-Received: from localhost ([::1]:53170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyXXW-0004Iu-6D for ged-emacs-devel@m.gmane.org; Wed, 21 Mar 2018 02:48:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyXWf-0004Gn-PR for emacs-devel@gnu.org; Wed, 21 Mar 2018 02:47:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyXWb-00034h-R9 for emacs-devel@gnu.org; Wed, 21 Mar 2018 02:47:09 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyXWb-00034Z-N7; Wed, 21 Mar 2018 02:47:05 -0400 Original-Received: from [176.228.60.248] (port=1616 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eyXWa-0002Qj-Ud; Wed, 21 Mar 2018 02:47:05 -0400 In-reply-to: (message from Sebastian Sturm on Wed, 21 Mar 2018 01:36:38 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223875 Archived-At: > From: Sebastian Sturm > Date: Wed, 21 Mar 2018 01:36:38 +0100 > > this is the profiler report I get for the slow case (BTW, is there a way > to have the profiler resolve functions within line-number-at-pos? Yes: load simple.el manually before running the benchmark. > with perf, the ("self") time taken by buf_charpos_to_bytepos increases > from ~60% (fast case) to >98%. This is the diff generated by perf diff > : > > # Event 'cycles' > # > # Baseline Delta Shared Object Symbol > > # ........ ....... .................... > .......................................... > # > 57.77% +40.30% emacs-27.0.50 [.] buf_charpos_to_bytepos This seems to confirm Stefan's guess that converting character positions to byte positions takes most of the time, which might make sense with a lot of overlays (because each overlay uses 2 markers). Does your code call line-number-at-pos at random positions in the buffer, or are the positions close to one another? If the latter, you might be better off calling count-lines directly, starting at the line where you previously calculated the line number, instead of calling line-number-at-pos, which always begins at point-min.