From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Finding macro-generated ert test definitions (WAS: [Emacs-diffs] master bb591f139f: Enhance CC Mode's fontification, etc., of unterminated strings.) Date: Thu, 24 May 2018 19:41:14 +0300 Message-ID: <83efi1atw5.fsf@gnu.org> References: <83r2m2cthd.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1527179950 11003 195.159.176.226 (24 May 2018 16:39:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 24 May 2018 16:39:10 +0000 (UTC) Cc: acm@muc.de, emacs-devel@gnu.org, joaotavora@gmail.com, tino.calancha@gmail.com To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 24 18:39:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLtGb-0002m4-Qz for ged-emacs-devel@m.gmane.org; Thu, 24 May 2018 18:39:05 +0200 Original-Received: from localhost ([::1]:39767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLtIj-0007m3-3I for ged-emacs-devel@m.gmane.org; Thu, 24 May 2018 12:41:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLtIa-0007km-3b for emacs-devel@gnu.org; Thu, 24 May 2018 12:41:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLtIW-0002cJ-4R for emacs-devel@gnu.org; Thu, 24 May 2018 12:41:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLtIW-0002cF-1L; Thu, 24 May 2018 12:41:04 -0400 Original-Received: from [176.228.60.248] (port=3955 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fLtIV-0004zs-Em; Thu, 24 May 2018 12:41:03 -0400 In-reply-to: (message from Noam Postavsky on Wed, 23 May 2018 18:40:24 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225661 Archived-At: > From: Noam Postavsky > Date: Wed, 23 May 2018 18:40:24 -0400 > Cc: João Távora , > Alan Mackenzie , Tino Calancha , > Emacs developers > > How's this? > > --- i/doc/misc/ert.texi > +++ w/doc/misc/ert.texi > @@ -386,5 +386,10 @@ How to Write Tests > > +@findex ert-find-test-other-window > Just like @code{find-function} is only able to find where a function > was defined if the function was loaded from a file, ERT is only able > -to find where a test was defined if the test was loaded from a file. > +to find where a test was defined (via > +@code{ert-find-test-other-window}) if the test was loaded from a file. > +Since this relies on a textual search of the source, it will likely > +fail if you use a macro which expands into the @code{ert-deftest} > +form, especially if the test name itself is absent from the source. Looks like a good addition, thanks.