From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0a6a2fb: Improve documentation of several recent changes Date: Sat, 16 Jun 2018 18:58:01 +0300 Message-ID: <83efh6zpti.fsf@gnu.org> References: <20180616101224.6099.14566@vcs0.savannah.gnu.org> <20180616101226.5451B2043E@vcs0.savannah.gnu.org> <235737a3-dfa7-d464-bef2-8ae9b365683f@dancol.org> <83k1qyzs49.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1529164606 30401 195.159.176.226 (16 Jun 2018 15:56:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 15:56:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Daniel Colascione" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 16 17:56:42 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUDZB-0007lM-4P for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 17:56:41 +0200 Original-Received: from localhost ([::1]:51916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUDbG-0001a1-Rd for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 11:58:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUDaf-0001Zg-N4 for emacs-devel@gnu.org; Sat, 16 Jun 2018 11:58:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUDac-0001yn-Mn for emacs-devel@gnu.org; Sat, 16 Jun 2018 11:58:13 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUDac-0001ye-Is; Sat, 16 Jun 2018 11:58:10 -0400 Original-Received: from [176.228.60.248] (port=3881 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fUDab-0006Uw-Mt; Sat, 16 Jun 2018 11:58:10 -0400 In-reply-to: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226369 Archived-At: > Date: Sat, 16 Jun 2018 08:21:04 -0700 > From: "Daniel Colascione" > Cc: "Daniel Colascione" , > emacs-devel@gnu.org > > >> face-filters-always-match is deliberately not mentioned in the elisp > >> manual. It's for face-remap.el's use only. Please remove the additional > >> text about it. > > > > I'll take it as a THANK YOU > > Well, that too. :-) You are welcome. As for documentation of face-filters-always-match: if we want it to be an internal variable, let's name it as such, and let's say in the doc string something like "Internal use only." Then removing it from the manual will be a logical step. See, that's why documenting features by those who write the code is preferable: just by looking at the variable's name, doc string, and uses (or lack thereof), it was hard for me to say what was the original intent.