all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 32024@debbugs.gnu.org
Subject: bug#32024: 27.0; [PATCH] `imenu--generic-function'
Date: Sat, 07 Jul 2018 12:18:29 +0300	[thread overview]
Message-ID: <83efgfjtei.fsf@gnu.org> (raw)
In-Reply-To: <e96656c3-9a71-4da1-9f7d-7e551026874b@default> (message from Drew Adams on Sat, 30 Jun 2018 15:53:22 -0700 (PDT))

> Date: Sat, 30 Jun 2018 15:53:22 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> 
> Attached is a patch for two bugs in `imenu--generic-function'.  I ran
> into them when using a function value for argument REGEXP, though
> neither has to do particularly with that use case.  Instead, they both
> have to do with the case where items are within comments or strings,
> which might be skipped.
> 
> 1. When checking whether the current item is inside a comment or string,
>    it's necessary to first move point to position START.  Otherwise, the
>    test is made at bol (which might not be within a comment or string,
>    even though the START position is).
> 
> 2. At the end, it's necessary to remove any empty menus that could have
>    been added.  That can happen because of skipping things inside
>    comments or strings.

Thanks.

Applying this produces the following warning from the byte compiler:

  In end of data:
  imenu.el:1056:1:Warning: the function `imenup-delete-if-not' is not known to
      be defined.

And indeed, I cannot find that function anywhere in Emacs.





  reply	other threads:[~2018-07-07  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-30 22:53 bug#32024: 27.0; [PATCH] `imenu--generic-function' Drew Adams
2018-07-07  9:18 ` Eli Zaretskii [this message]
     [not found] <<e96656c3-9a71-4da1-9f7d-7e551026874b@default>
     [not found] ` <<83efgfjtei.fsf@gnu.org>
2018-07-07 14:27   ` Drew Adams
2018-07-07 16:22     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83efgfjtei.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=32024@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.