all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: kyle@jonathanmitchell.org
Cc: 32038-done@debbugs.gnu.org, k.michal@zoho.com
Subject: bug#32038: 27.0.50; Emacs hangs when using :propertize mode line construct and not providing a property value
Date: Sat, 14 Jul 2018 14:30:04 +0300	[thread overview]
Message-ID: <83efg6awcj.fsf@gnu.org> (raw)
In-Reply-To: <0e98e4beb51785ef2842a229b31e30e3ceed43e7.camel@jonathanmitchell.org> (message from Jonathan Kyle Mitchell on Wed, 04 Jul 2018 23:14:01 -0500)

> From: Jonathan Kyle Mitchell <kyle@jonathanmitchell.org>
> Cc: k.michal@zoho.com, 32038@debbugs.gnu.org
> Date: Wed, 04 Jul 2018 23:14:01 -0500
> 
> That makes sense. I added one function to call Fset_text_properties
> through internal_condition_case_n in the attached revised patch. The
> error gets caught and safe_eval_handler appends an error message to the
> *Messages* buffer.
> 
> The error message is put in *Messages* on the first time only though,
> subsequent (force-mode-line-update) calls just append nil. I don't know
> if that's expected for redisplay's internal messaging routines.
> 
> Thanks for reviewing the patch.

Thanks, I pushed this to the master branch, and I'm marking the bug
done.

> From 621bc3df19eaf2258c9a2ec0c72004ea8336ce0f Mon Sep 17 00:00:00 2001
> From: Jonathan Kyle Mitchell <kyle@jonathanmitchell.org>
> Date: Wed, 4 Jul 2018 22:38:29 -0500
> Subject: [PATCH] Call Fset_text_properties through internal_condition_case_n
> 
> * xdisp.c (display_mode_element, safe_set_text_properties):

The header line and the log message are sub-optimal/incomplete, and
don't mention the bug number.  Please see how I fixed that in the
actual commit, and try following this example in the future.





  reply	other threads:[~2018-07-14 11:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 16:15 bug#32038: 27.0.50; Emacs hangs when using :propertize mode line construct and not providing a property value Michał Kondraciuk
2018-07-03  1:24 ` Jonathan Kyle Mitchell
2018-07-03  4:46   ` Jonathan Kyle Mitchell
2018-07-04  3:12     ` Jonathan Kyle Mitchell
2018-07-04 15:07       ` Eli Zaretskii
2018-07-05  4:14         ` Jonathan Kyle Mitchell
2018-07-14 11:30           ` Eli Zaretskii [this message]
2018-07-15 17:21             ` Jonathan Kyle Mitchell
2018-07-21 16:39 ` bug#32237: 27.0.50; Function in before-change-functions is called with first argument greater than the second Michał Kondraciuk
2018-07-21 18:06   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83efg6awcj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=32038-done@debbugs.gnu.org \
    --cc=k.michal@zoho.com \
    --cc=kyle@jonathanmitchell.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.