From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32257: 26.1; read-multiple-choice inf loops on mouse clicks Date: Fri, 27 Jul 2018 15:30:33 +0300 Message-ID: <83effosvx2.fsf@gnu.org> References: <87muug4z52.fsf@gmail.com> <87y3dy3i05.fsf@gmail.com> <83muudrqol.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532694561 16168 195.159.176.226 (27 Jul 2018 12:29:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Jul 2018 12:29:21 +0000 (UTC) Cc: 32257@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 27 14:29:16 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj1rw-00046n-Bq for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 14:29:16 +0200 Original-Received: from localhost ([::1]:40970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj1u3-0006dO-5z for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 08:31:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj1tj-0006cJ-C8 for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 08:31:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj1te-0004mX-Ea for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 08:31:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fj1te-0004mT-9D for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 08:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fj1te-00044d-3B for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 08:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jul 2018 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32257-submit@debbugs.gnu.org id=B32257.153269464215632 (code B ref 32257); Fri, 27 Jul 2018 12:31:02 +0000 Original-Received: (at 32257) by debbugs.gnu.org; 27 Jul 2018 12:30:42 +0000 Original-Received: from localhost ([127.0.0.1]:59692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj1tK-000443-Lu for submit@debbugs.gnu.org; Fri, 27 Jul 2018 08:30:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj1tH-00043n-Cu for 32257@debbugs.gnu.org; Fri, 27 Jul 2018 08:30:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj1tB-0004fj-HC for 32257@debbugs.gnu.org; Fri, 27 Jul 2018 08:30:34 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj1tB-0004fb-D1; Fri, 27 Jul 2018 08:30:33 -0400 Original-Received: from [176.228.60.248] (port=2931 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fj1tA-0007ly-2g; Fri, 27 Jul 2018 08:30:32 -0400 In-reply-to: (message from Andy Moreton on Fri, 27 Jul 2018 12:35:27 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149013 Archived-At: > From: Andy Moreton > Date: Fri, 27 Jul 2018 12:35:27 +0100 > > > If we want this change on emacs-26, we should carefully audit all the > > other users of rmc.el (and in generally, I'd prefer some more local > > change in nsm.el on the release branch). We've had our share of > > subtle bugs introduced by switching to an "almost-compatible" method > > of reading input. > > read-multiple choice only has two callers (`nsm-query-user' and > `message-fix-before-sending') in both master and emacs-26. In Emacs, yes. But what about the world out there? > While I understand caution over changes to emacs-26, the only place that > needs fixing is read-multiple-choice. It seems odd to prefer changes > in its callers, that will more likely introduce additional bugs without > fixing the original issue. In case it wasn't clear I meant to make a safer change on emacs-26, and change read-multiple-choice on master.