From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 33205@debbugs.gnu.org
Subject: bug#33205: 26.1; unibyte/multibyte missing in rx.el
Date: Sat, 29 Dec 2018 11:23:18 +0200 [thread overview]
Message-ID: <83efa0660p.fsf@gnu.org> (raw)
In-Reply-To: <5203F729-8090-4453-80CC-1249DB064631@acm.org> (message from Mattias Engdegård on Mon, 19 Nov 2018 21:07:39 +0100)
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Mon, 19 Nov 2018 21:07:39 +0100
> Cc: 33205@debbugs.gnu.org
>
> Perhaps you want me to open a new bug for the above? I'm attaching a patch all the same, but you may prefer doing it differently.
Thanks, I have some comments.
First, please provide a ChangeLog-style commit log message describing
the changes. See CONTRIBUTE for more details.
> + "Turn a string argument to `any' into a list of characters and, representing
> +ranges, dotted pairs of characters. The original order is not preserved."
The first line of a doc string should be a single full sentence, and
it should mention the arguments of the function. Also, the first
sentence confused me: what do you mean by this part:
"... and, representing ranges, dotted pairs of characters"
Finally, please use the US English convention of leaving 2 spaces
between sentences in the documentation.
> + (let ((decode-char
> + ;; Make sure raw bytes are decoded as such, to avoid confusion with
> + ;; U+0080..U+00FF.
> + (if (multibyte-string-p str)
> + #'identity
> + (lambda (c) (if (and (>= c #x80) (<= c #xff))
> + (+ c #x3fff00)
> + c))))
> + (len (length str))
> + (i 0)
> + (ret nil))
> + (while (< i len)
> + (cond ((and (< i (- len 2))
> + (= (aref str (+ i 1)) ?-))
> + ;; Range.
> + (let ((start (funcall decode-char (aref str i)))
> + (end (funcall decode-char (aref str (+ i 2)))))
> + (cond ((< start end) (push (cons start end) ret))
> + ((= start end) (push start ret)))
> + (setq i (+ i 3))))
> + (t
> + ;; Single character.
> + (push (funcall decode-char (aref str i)) ret)
> + (setq i (+ i 1)))))
> + ret))
This seems to have dropped the validity check which signaled an error
in the original code? Any reason for that?
Thanks.
next prev parent reply other threads:[~2018-12-29 9:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 15:03 bug#33205: 26.1; unibyte/multibyte missing in rx.el Mattias Engdegård
2018-10-30 17:27 ` Eli Zaretskii
2018-10-31 15:27 ` Mattias Engdegård
2018-10-31 15:55 ` Eli Zaretskii
2018-11-05 16:49 ` Eli Zaretskii
2018-11-07 18:08 ` Mattias Engdegård
2018-11-07 19:10 ` Eli Zaretskii
2018-11-07 20:19 ` Mattias Engdegård
2018-11-19 20:07 ` Mattias Engdegård
2018-12-08 8:56 ` Eli Zaretskii
2018-12-08 9:23 ` Mattias Engdegård
2018-12-08 11:11 ` Eli Zaretskii
2018-12-28 18:17 ` Mattias Engdegård
2018-12-29 9:24 ` Eli Zaretskii
2018-12-29 9:23 ` Eli Zaretskii [this message]
2018-12-29 10:43 ` Mattias Engdegård
2018-12-29 14:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83efa0660p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33205@debbugs.gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.