all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Devon Sean McCullough <Emacs-Hacker2018@jovi.net>
Cc: 33669-done@debbugs.gnu.org
Subject: bug#33669: 26.1; Buffer-menu-mode bad UX
Date: Sat, 12 Jan 2019 13:53:28 +0200	[thread overview]
Message-ID: <83ef9if5xj.fsf@gnu.org> (raw)
In-Reply-To: <0D3D3224-4085-4608-9367-02F51D74B528@jovi.net> (message from Devon Sean McCullough on Sat, 5 Jan 2019 10:36:22 -0500)

> From: Devon Sean McCullough <Emacs-Hacker2018@jovi.net>
> Date: Sat, 5 Jan 2019 10:36:22 -0500
> 
> > On Jan 5, 2019, at 3:44 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Ping!  Ping!  Devon, could you please try the proposed fix?
> 
> The original and patched versions both look problematic.  Instead, I had good results with
> 
> --- old/buff-menu.el	2019-01-05 10:26:45.000000000 -0500
> +++ new/buff-menu.el	2019-01-05 10:27:23.000000000 -0500
> @@ -475,10 +475,10 @@
>  			   (save-buffer))
>  			 (tabulated-list-set-col 2 " " t))
>  		     (error (warn "Error saving %s" buffer))))
> -		 (if delete
> -		     (unless (eq buffer (current-buffer))
> -		       (kill-buffer buffer)
> -		       (tabulated-list-delete-entry))
> +		 (if (and delete
> +			  (not (eq buffer (current-buffer)))
> +                          (kill-buffer buffer))
> +                     (tabulated-list-delete-entry)
>  		   (forward-line 1)))))))))
>  
>  (defun Buffer-menu-select ()
> 

Thanks, pushed to the emacs-26 branch.





      parent reply	other threads:[~2019-01-12 11:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-08  2:06 bug#33669: 26.1; Buffer-menu-mode bad UX Devon Sean McCullough
2018-12-08 11:07 ` Eli Zaretskii
2018-12-22 10:50   ` Eli Zaretskii
2019-01-05  8:44     ` Eli Zaretskii
     [not found]       ` <0D3D3224-4085-4608-9367-02F51D74B528@jovi.net>
2019-01-12 11:53         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ef9if5xj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33669-done@debbugs.gnu.org \
    --cc=Emacs-Hacker2018@jovi.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.