From: Eli Zaretskii <eliz@gnu.org>
To: Konstantin Kharlamov <hi-angel@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line
Date: Tue, 19 Mar 2019 08:47:05 +0200 [thread overview]
Message-ID: <83ef73uzrq.fsf@gnu.org> (raw)
In-Reply-To: <1552945510.7027.2@yandex.ru> (message from Konstantin Kharlamov on Tue, 19 Mar 2019 00:45:10 +0300)
> Date: Tue, 19 Mar 2019 00:45:10 +0300
> From: Konstantin Kharlamov <hi-angel@yandex.ru>
> Cc: emacs-devel@gnu.org
>
> > 1. Why was the amount of whitespace in the tags table different from
> > that in the source file?
>
> It's a bug in anjuta-tags
So if/when that bug is fixed (maybe it's fixed already), there will be
no reason to make changes in etags.el?
> > 3. Why are the issue and you talking about "trailing whitespace",
> > while the difference between Expected and Actual in the issue is
> > in leading whitespace, not trailing whitespace?
>
> Sorry for confusion here, I was imagining: given a string, whitespace
> may "trail" on both sides of it. But I'm not a native speaker.
OK, no problem. I guessed something like that.
> Okay, whatever. I get your position. Though I disagree, but we clearly
> have different priorities here: while I'm focusing on a Emacs user,
> you're focusing on technical correctness.
It's not just technical correctness. etags.el is used for a very
large number of different "languages" (some of them are not
programming languages at all, like HTML), so any syntactic change that
might be a no-brainer for programming languages could break some other
"language" we currently support.
> Can my 1-st patch from the series be merged though?
I will review that soon, please wait for a little bit longer. I'm
somewhat hard-pressed for free time lately. (Or maybe someone else
here could volunteer to review that sooner?)
next prev parent reply other threads:[~2019-03-19 6:47 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 1:53 [PATCH 1/3] lisp/progmodes/etags.el clean up code by removing a temporary Konstantin Kharlamov
2019-03-16 1:53 ` [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Konstantin Kharlamov
2019-03-16 12:43 ` Eli Zaretskii
2019-03-16 15:42 ` Konstantin Kharlamov
2019-03-16 16:00 ` Stefan Monnier
2019-03-16 16:26 ` Eli Zaretskii
2019-03-16 21:12 ` Konstantin Kharlamov
2019-03-16 21:47 ` Konstantin Kharlamov
2019-03-17 3:36 ` Eli Zaretskii
2019-03-17 3:41 ` Konstantin Kharlamov
2019-03-17 15:17 ` Eli Zaretskii
2019-03-17 15:52 ` Stefan Monnier
2019-03-17 16:13 ` Eli Zaretskii
2019-03-17 17:36 ` Stefan Monnier
2019-03-17 21:14 ` Eradicating selective-display == t (was: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line) Stefan Monnier
2019-03-17 21:32 ` Konstantin Kharlamov
2019-03-18 1:12 ` Eradicating selective-display == t Stefan Monnier
2019-03-18 9:16 ` Konstantin Kharlamov
2019-03-18 12:10 ` Stefan Monnier
2019-03-17 19:06 ` [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Konstantin Kharlamov
2019-03-17 19:22 ` Eli Zaretskii
2019-03-17 19:29 ` Konstantin Kharlamov
2019-03-17 20:21 ` Eli Zaretskii
2019-03-17 20:27 ` Konstantin Kharlamov
2019-03-17 20:40 ` Eli Zaretskii
2019-03-17 20:44 ` Konstantin Kharlamov
2019-03-18 3:34 ` Eli Zaretskii
2019-03-18 9:43 ` Konstantin Kharlamov
2019-03-18 9:57 ` Konstantin Kharlamov
2019-03-18 17:00 ` Eli Zaretskii
2019-03-18 19:15 ` Konstantin Kharlamov
2019-03-18 19:25 ` Konstantin Kharlamov
2019-03-18 20:16 ` Eli Zaretskii
2019-03-18 21:45 ` Konstantin Kharlamov
2019-03-18 23:13 ` Konstantin Kharlamov
2019-03-18 23:38 ` Konstantin Kharlamov
2019-03-19 1:46 ` Stefan Monnier
2019-03-19 6:47 ` Eli Zaretskii [this message]
2019-03-16 1:53 ` [PATCH 3/3] lisp/progmodes/etags.el improve match by string trimming Konstantin Kharlamov
2019-03-16 2:13 ` [PATCH v2] " Konstantin Kharlamov
2019-03-16 12:46 ` Eli Zaretskii
2019-03-16 15:38 ` Konstantin Kharlamov
2019-03-16 16:29 ` Eli Zaretskii
2019-03-17 2:38 ` [PATCH v3] " Konstantin Kharlamov
2019-03-19 6:55 ` [PATCH v2] lisp/progmodes/etags.el clean up code by removing a temporary Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ef73uzrq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=hi-angel@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.