From: Eli Zaretskii <eliz@gnu.org>
To: Alex <agrambot@gmail.com>
Cc: 35058@debbugs.gnu.org
Subject: bug#35058: [PATCH] Use display-graphic-p in more cases
Date: Tue, 02 Apr 2019 20:23:00 +0300 [thread overview]
Message-ID: <83ef6kfhjf.fsf@gnu.org> (raw)
In-Reply-To: <87d0m4pcca.fsf@gmail.com> (message from Alex on Tue, 02 Apr 2019 11:05:09 -0600)
> From: Alex <agrambot@gmail.com>
> Cc: 35058@debbugs.gnu.org
> Date: Tue, 02 Apr 2019 11:05:09 -0600
>
> >> On non-window systems, always use the meta modifier.
> >>
> >> So I changed the eq call to display-graphics-p. Is it okay to follow the
> >> docstring here?
> >
> > No, not IMO. Doc strings can change because their purpose is
> > documentation that's useful to users and programmers, whereas the
> > issue in hand is ease of future maintenance.
>
> Hmm, it seems that my terminal Emacs accepts the super modifier but not
> the hyper modifier; is this a bug in Emacs?
I don't know. What do you mean by "accept"?
> Should I remove the window-system condition even if I can't get
> terminal Emacs to recognize the hyper key?
If it is very inconvenient to use hyper on text terminals, then I
think we shouldn't require users to do that.
> >> The definition of blink-cursor mode states:
> >>
> >> This command is effective only on graphical frames. On text-only
> >> terminals, cursor blinking is controlled by the terminal."
> >
> > That's the _current_ situation. But what would preclude the xterm
> > developers, say, from adding a way of controlling that? Nothing in
> > particular, I'd say.
>
> I agree that it's possible for the behaviour to be different eventually,
> but in the meantime display-graphic-p describes the current situation
> and intent better than the explicit memq does.
>
> If text-only terminals gain the ability to control this behaviour, then
> that's the time to remove the check, no?
How will you know which tests to remove? If the predicate was named
display-blink-cursor-p, then you'd know immediately, but if the
predicate is display-graphic-p, you'd need to decide which of those to
remove and which not to remove. These predicates exist to make the
decision easy.
> I believe so. I'd like to replace the memq with a descriptive name, but
> I'm not sure what to call it; display-ascii-encoding-p to denote that
> the display can not differentiate between, e.g., C-m and RET?
You mean, C-m/RET on the one hand and [return] on the other, right? I
think a new predicate could be beneficial, because the function keys
are supported on some text terminals, for example on MS-Windows. How
about display-function-keys-p?
> > Not IMO, because this is again about selection with a mouse, something
> > that can (and is) supported on some TTY frames. We could use the
> > hypothetical display-iconifiable-p (but we should then find a better
> > name, something about selecting/raising frames perhaps).
>
> display-multi-focus-p? But maybe that implies that it can focus on
> multiple frames simultaneously.
display-can-raise-frames-p or something. (But I'm not good with
coming up with names.)
> What about using display-multi-frame-p? Could there be some system
> that allows multiple frames, but no way to select between them?
Text terminals can support multiple frames, so display-multi-frame-p
is not what we want here.
next prev parent reply other threads:[~2019-04-02 17:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 23:38 bug#35058: [PATCH] Use display-graphic-p in more cases Alex
2019-03-31 12:45 ` Basil L. Contovounesios
2019-03-31 15:37 ` Eli Zaretskii
2019-04-01 4:15 ` Alex
2019-04-01 5:21 ` Eli Zaretskii
2019-04-02 17:05 ` Alex
2019-04-02 17:23 ` Eli Zaretskii [this message]
2019-04-02 17:57 ` Alex
2019-04-02 18:39 ` Eli Zaretskii
2019-04-03 5:14 ` Alex
2019-04-03 5:29 ` Eli Zaretskii
2019-04-03 20:26 ` Alex
2019-04-05 7:29 ` Eli Zaretskii
2019-04-05 16:35 ` Alex
2019-04-05 18:51 ` Eli Zaretskii
2019-04-07 5:11 ` Alex
[not found] ` <<83a7hagv11.fsf@gnu.org>
2019-04-01 14:32 ` Drew Adams
2019-04-06 7:18 ` Eli Zaretskii
2019-04-07 13:50 ` Stefan Monnier
[not found] <<8736n4ndav.fsf@gmail.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ef6kfhjf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=35058@debbugs.gnu.org \
--cc=agrambot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.