From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Mon, 15 Apr 2019 18:21:53 +0300 Message-ID: <83ef63i99q.fsf@gnu.org> References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> <1555340495.24928.3@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="103168"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org, rms@gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 15 17:23:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hG3S6-000QiB-1l for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 17:23:22 +0200 Original-Received: from localhost ([127.0.0.1]:51660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG3S4-0002ND-Vq for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 11:23:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG3Rq-0002Lp-5U for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 11:23:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG3Rp-000257-1V for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 11:23:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49932) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hG3Rl-00023S-Uz for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 11:23:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hG3Rl-0001Vx-QC for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 11:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2019 15:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.15553417395756 (code B ref 35062); Mon, 15 Apr 2019 15:23:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 15 Apr 2019 15:22:19 +0000 Original-Received: from localhost ([127.0.0.1]:35243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG3R5-0001Um-8M for submit@debbugs.gnu.org; Mon, 15 Apr 2019 11:22:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG3R2-0001UW-K1 for 35062@debbugs.gnu.org; Mon, 15 Apr 2019 11:22:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG3Qw-0001Tm-1p; Mon, 15 Apr 2019 11:22:10 -0400 Original-Received: from [176.228.60.248] (port=2120 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hG3Qo-0000yU-Ev; Mon, 15 Apr 2019 11:22:03 -0400 In-reply-to: <1555340495.24928.3@yandex.ru> (message from Konstantin Kharlamov on Mon, 15 Apr 2019 18:01:35 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157661 Archived-At: > Date: Mon, 15 Apr 2019 18:01:35 +0300 > From: Konstantin Kharlamov > Cc: rms@gnu.org, 35062@debbugs.gnu.org > > > That's true, but this is not such a situation: the original changes > > were never committed without any modifications. > > Well, given the line my patch modifies has no changes, the only > modification was the commit message. My only mistake was not knowing > that UTF8 is prohibited. But really, it's a 2 symbols text replacement, > me or you could just replace it. No, the log message was not the problem. Look at the code changes, they were the ones I modified. > Is there an extra work? The changes you added can be commited with α) > git commit --amend -v, or β) git commit -v. You did α, which only > differs from β by a number of characters, that is ironically smaller > in β. Yes, this is extra work: it requires one more commit. More steps, more opportunities to make mistakes, etc. And that's if I'm not interrupted in the middle of it by something in Real Life, or someone pushes to upstream in-between, and I need to pull again and perhaps resolve conflicts. I'd rather avoid such complications for a simple job like that. > > You can always use "git log --grep" to find references to your > > contributions in the log messages. And the log message includes a > > reference to the bug number, where you can refer people for your > > actual contribution. > > Who would attach a bunch of commit messages to a CV? I don't know. When I interview software engineers, I don't ask them for such details, I can look up their contributions myself, given just the repository URL. > Sorry, I actually feel embarassed that I discussing a trivial one-liner > patch :D But I can't stop thinking that this could've happened with a > non-one-line or maybe one-line but non-trivial contribution… We are splitting hair, for sure. I think you are unfamiliar with our procedures, and try too hard to find aspects that you saw elsewhere. If so, it's a temporary difficulty.