From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Remove display member of glyph_string
Date: Thu, 09 May 2019 08:50:13 +0300
Message-ID: <83ef58goru.fsf@gnu.org>
References: <87a7fwe12f.fsf@gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="54266"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Alex Gramiak <agrambot@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 09 07:51:04 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hObxQ-000E0G-0n
	for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 07:51:04 +0200
Original-Received: from localhost ([127.0.0.1]:48460 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hObxN-0000Vo-2w
	for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 01:51:02 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:42810)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hObwm-0000Vh-D3
	for emacs-devel@gnu.org; Thu, 09 May 2019 01:50:25 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36614)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hObwm-0006hg-AL; Thu, 09 May 2019 01:50:24 -0400
Original-Received: from [176.228.60.248] (port=2830 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hObwl-0002g0-Rq; Thu, 09 May 2019 01:50:24 -0400
In-reply-to: <87a7fwe12f.fsf@gmail.com> (message from Alex Gramiak on Wed, 08
	May 2019 21:52:56 -0600)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236323
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236323>

> From: Alex Gramiak <agrambot@gmail.com>
> Date: Wed, 08 May 2019 21:52:56 -0600

Each FRAME_X_DISPLAY call expands into applying a struct offset 4
times.  Do we care about the (small) additional inefficiency?  AFAIU,
that was the cause for maintaining the result inside the glyph_string
structure in the first place.

> The only other location that FRAME_X_DISPLAY appears in non-X code is in
> the argument to Free_Pixmap in image.c, which can hopefully be
> refactored out in a later patch; at that point the other terms can
> remove their trivial FRAME_X_DISPLAY definitions.

So should we do both in one go, perhaps?

Thanks.