From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36405: 26.2.90; O_PATH problem on some versions of Cygwin Date: Sat, 29 Jun 2019 10:06:49 +0300 Message-ID: <83ef3chnue.fsf@gnu.org> References: <9308fcb1-bb7e-229b-aacf-8c55db00fca6@cornell.edu> <83k1d6i5vl.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="215332"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36405@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 29 09:08:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hh7TO-000tsm-VN for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2019 09:08:35 +0200 Original-Received: from localhost ([::1]:38092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hh7TN-0006Y1-5m for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2019 03:08:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39661) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hh7Sw-0006Xt-4a for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:08:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hh7Su-0004RX-FJ for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:08:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58019) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hh7Ss-0004Nx-5q for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hh7Sr-0002dk-UA for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2019 07:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36405 X-GNU-PR-Package: emacs Original-Received: via spool by 36405-submit@debbugs.gnu.org id=B36405.156179202910089 (code B ref 36405); Sat, 29 Jun 2019 07:08:01 +0000 Original-Received: (at 36405) by debbugs.gnu.org; 29 Jun 2019 07:07:09 +0000 Original-Received: from localhost ([127.0.0.1]:43330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hh7S1-0002cf-4O for submit@debbugs.gnu.org; Sat, 29 Jun 2019 03:07:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hh7Rz-0002cT-BF for 36405@debbugs.gnu.org; Sat, 29 Jun 2019 03:07:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hh7Rt-0003Ej-G2; Sat, 29 Jun 2019 03:07:01 -0400 Original-Received: from [176.228.60.248] (port=1785 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hh7Rs-0003u9-Gi; Sat, 29 Jun 2019 03:07:01 -0400 In-reply-to: (message from Paul Eggert on Fri, 28 Jun 2019 23:26:09 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161795 Archived-At: > Cc: 36405@debbugs.gnu.org, kbrown@cornell.edu > From: Paul Eggert > Date: Fri, 28 Jun 2019 23:26:09 -0700 > > Eli Zaretskii wrote: > > What problems did you see/envision on other platforms with the > > original patch? > > Mainly the hassle of maintaining code with a lot of hard-to-read ifdefs in it. > It's better if system-specific stuff is kept to a minimum in mainline code. I agree, of course. But in this case we are talking about adding 2 #ifdef's, so the situation is not much worse than it was before. > Also, this O_PATH stuff is not that high of a priority, as the code works quite > well in practice without O_PATH. It was evidently important enough for us to use it on platforms that support it. > How about something like the attached patch instead? It's simpler and should be > a bit faster on Cygwin than the original patch. I haven't tested it. Thanks, this is fine with me if it does the job. Ken?