all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 36405@debbugs.gnu.org
Subject: bug#36405: 26.2.90; O_PATH problem on some versions of Cygwin
Date: Sat, 29 Jun 2019 10:06:49 +0300	[thread overview]
Message-ID: <83ef3chnue.fsf@gnu.org> (raw)
In-Reply-To: <cd1ada3b-c764-e2bd-d3ac-4b87000b5250@cs.ucla.edu> (message from Paul Eggert on Fri, 28 Jun 2019 23:26:09 -0700)

> Cc: 36405@debbugs.gnu.org, kbrown@cornell.edu
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 28 Jun 2019 23:26:09 -0700
> 
> Eli Zaretskii wrote:
> > What problems did you see/envision on other platforms with the
> > original patch?
> 
> Mainly the hassle of maintaining code with a lot of hard-to-read ifdefs in it. 
> It's better if system-specific stuff is kept to a minimum in mainline code. 

I agree, of course.  But in this case we are talking about adding 2
#ifdef's, so the situation is not much worse than it was before.

> Also, this O_PATH stuff is not that high of a priority, as the code works quite 
> well in practice without O_PATH.

It was evidently important enough for us to use it on platforms that
support it.

> How about something like the attached patch instead? It's simpler and should be 
> a bit faster on Cygwin than the original patch. I haven't tested it.

Thanks, this is fine with me if it does the job.  Ken?





  reply	other threads:[~2019-06-29  7:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 19:28 bug#36405: 26.2.90; O_PATH problem on some versions of Cygwin Ken Brown
2019-06-27 20:47 ` Paul Eggert
2019-06-28  6:25   ` Eli Zaretskii
2019-06-29  6:26     ` Paul Eggert
2019-06-29  7:06       ` Eli Zaretskii [this message]
2019-06-29 18:03         ` Ken Brown
2019-06-29 18:19           ` Eli Zaretskii
2019-06-28 17:57   ` Ken Brown
2019-06-29  6:20     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ef3chnue.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=36405@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.