From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36167: [PATCH v2] Replace manually crafted hex regexes with [[:xdigit:]] Date: Mon, 08 Jul 2019 15:11:54 +0300 Message-ID: <83ef307mk5.fsf@gnu.org> References: <1562578472.8519.0@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60722"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36167@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 08 14:19:34 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkScG-000FYJ-LF for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 14:19:32 +0200 Original-Received: from localhost ([::1]:41206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkSW8-0006LP-RC for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 08:13:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59636) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkSW3-0006In-2h for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 08:13:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkSW0-0002t9-GR for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 08:13:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkSVy-0002sH-6Z for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 08:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hkSVy-00044g-0t for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 08:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2019 12:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.156258794715607 (code B ref 36167); Mon, 08 Jul 2019 12:13:01 +0000 Original-Received: (at 36167) by debbugs.gnu.org; 8 Jul 2019 12:12:27 +0000 Original-Received: from localhost ([127.0.0.1]:57999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkSVO-00043f-K8 for submit@debbugs.gnu.org; Mon, 08 Jul 2019 08:12:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkSVL-00043L-V0 for 36167@debbugs.gnu.org; Mon, 08 Jul 2019 08:12:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hkSVE-0002Q3-HS; Mon, 08 Jul 2019 08:12:18 -0400 Original-Received: from [176.228.60.248] (port=3993 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hkSV9-0000qc-RY; Mon, 08 Jul 2019 08:12:14 -0400 In-reply-to: <1562578472.8519.0@yandex.ru> (message from Konstantin Kharlamov on Mon, 08 Jul 2019 12:34:32 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162322 Archived-At: > Date: Mon, 08 Jul 2019 12:34:32 +0300 > From: Konstantin Kharlamov > Cc: Eli Zaretskii > > > The log message was mis-formatted, which required me to tediously fix > > it by hand. Please in the future format the entries using "C-x 4 a" > > or similar commands, to avoid that, okay? In particular, lines longer > > than 78 characters abort "git am", so please verify this doesn't > > happen in the patches you submit. "C-x 4 a" and friends format the > > entries with leading TABs which you can later remove with "C-x TAB", > > and that produces the optimal results, including when the log messages > > are later used to generate ChangeLog files in the release tarballs. > > Thank you! And sorry about that. No sweat, mistakes do happen. > Anyway, IIRC I have used "C-x 4 a" to create the commit message, but > then I re-formatted it to look more similar to other commits I've > seen. Probably I shouldn't have touched it… Yes, my recommendation is to do only "C-u -8 C-x TAB" and nothing else to reformat the entries into commit log messages. This just removes the leading whitespace. Also, I recommend to have auto-fill-mode enabled in the buffer where you edit the log messages. > About git-am: this is unfortunate It isn't git-am per se, it's our hooks.