From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode Date: Wed, 07 Aug 2019 20:29:13 +0300 Message-ID: <83ef1wc2ae.fsf@gnu.org> References: <83wofwexkr.fsf@gnu.org> <20190805152747.4vyzejqoiy33l4ou@Ergus> <83tvatavmh.fsf@gnu.org> <20190807162033.hpphf2pbfo4p6vam@Ergus> <83h86taq4v.fsf@gnu.org> <20190807170654.b6wsccs3b2acduff@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="166565"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 07 19:30:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hvPlJ-000h9J-5P for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 19:30:09 +0200 Original-Received: from localhost ([::1]:43838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvPlI-0006SD-7r for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 13:30:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55223) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvPlE-0006Rq-8Y for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 13:30:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvPlD-0007bJ-Ce for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 13:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58724) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvPlD-0007b3-9h for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 13:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hvPlD-0003vm-3d for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 13:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2019 17:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36858 X-GNU-PR-Package: emacs Original-Received: via spool by 36858-submit@debbugs.gnu.org id=B36858.156519897115042 (code B ref 36858); Wed, 07 Aug 2019 17:30:03 +0000 Original-Received: (at 36858) by debbugs.gnu.org; 7 Aug 2019 17:29:31 +0000 Original-Received: from localhost ([127.0.0.1]:39312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvPkg-0003uY-MZ for submit@debbugs.gnu.org; Wed, 07 Aug 2019 13:29:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvPke-0003uI-OC for 36858@debbugs.gnu.org; Wed, 07 Aug 2019 13:29:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hvPkZ-0006Nq-Hp; Wed, 07 Aug 2019 13:29:23 -0400 Original-Received: from [176.228.60.248] (port=4883 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hvPkY-00007i-WB; Wed, 07 Aug 2019 13:29:23 -0400 In-reply-to: <20190807170654.b6wsccs3b2acduff@Ergus> (message from Ergus on Wed, 7 Aug 2019 19:06:54 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164726 Archived-At: > Date: Wed, 7 Aug 2019 19:06:54 +0200 > From: Ergus > Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com > > >(There's no need to make any changes for that, you can simply invoke > >dump-glyph-row or dump-glyph-matrix.) > > > How is it? Just invoke these functions, they dump the glyph row's contents, including the ends_at_zv_p, to stderr. > This issue is already fixed with the other condition I mentioned: > > IT_CHARPOS (*it) < ZV > > But ends_at_zv_p this also need to be fixed because there are some tests > inside extend_face_to_end_of_line that compare with ends_at_zv_p. In the > worst case we need to remove these comparisons. Not sure I understand why the comparisons need to be removed. Can you elaborate? > But ideally the flag must be set before right? In a buffer showing only buffer text (no after-strings at EOB), all the glyph rows starting from the one showing EOB have their ends_at_zv_p flag set.