From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org
Subject: bug#38406: 27.0.50; post-self-insert-hook does not hold its contract in cc-mode derived modes
Date: Fri, 06 Dec 2019 10:06:31 +0200 [thread overview]
Message-ID: <83eexhho8o.fsf@gnu.org> (raw)
In-Reply-To: <20191205201713.GC6252@ACM> (message from Alan Mackenzie on Thu, 5 Dec 2019 20:17:13 +0000)
> Date: Thu, 5 Dec 2019 20:17:13 +0000
> Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> > We never provide any "safety nets" for silly hook functions, so we
> > shouldn't do that here as well. OTOH, if someone puts a function on
> > those hooks which does something legitimate, we should meet their
> > expectations and let those functions run, as the contract says.
>
> I think that, with my latest patch, that is the case.
>
> > So I think you shouldn't filter anything from the hook before you run
> > it.
>
> I thought you were urging me to do precisely that two or three posts ago.
>
> I just tried taking a particular function off of
> c--unsafe-post-self-insert-hook-functions and enabling electric-pair
> mode. On typing a brace, electric-pair-mode threw an obscure error. It
> doesn't make sense to call electric-pair-post-self-insert-function twice
> for one keypress. That is a good reason for having that function
> filtered out of the hook.
There might be a misunderstanding on my part here. Could you please
explain how come electric-pair-post-self-insert-function is called
twice if it isn't removed from the hook? where's the second (or the
first) call?
> The root of the problem is the hook post-self-insert-hook. It is a
> thoroughly bad idea. The implications of introducing it a few years ago
> weren't thought through.
That might be so, but I think it's too late for removing it now.
> Assuming that removing this hook from Emacs isn't an option, we are
> left with ugly ad-hoc workarounds, such as the patch we're currently
> discussing.
Yes.
next prev parent reply other threads:[~2019-12-06 8:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 20:00 bug#38406: 27.0.50; post-self-insert-hook does not hold its contract in cc-mode derived modes yyoncho
2019-11-30 14:36 ` Alan Mackenzie
2019-12-01 10:02 ` yyoncho
2019-12-01 15:07 ` Alan Mackenzie
2019-12-01 15:27 ` yyoncho
2019-12-01 15:58 ` Alan Mackenzie
2019-12-01 18:03 ` Eli Zaretskii
2019-12-02 18:37 ` Alan Mackenzie
2019-12-01 17:59 ` Eli Zaretskii
2019-12-01 19:27 ` Alan Mackenzie
2019-12-01 20:47 ` Eli Zaretskii
2019-12-02 18:31 ` Alan Mackenzie
2019-12-02 20:17 ` Eli Zaretskii
2019-12-04 20:41 ` Alan Mackenzie
2019-12-04 21:04 ` Dmitry Gutov
2019-12-05 19:14 ` Alan Mackenzie
2019-12-05 20:44 ` Dmitry Gutov
2019-12-05 14:45 ` Eli Zaretskii
2019-12-05 19:09 ` Alan Mackenzie
2019-12-05 19:25 ` Eli Zaretskii
2019-12-05 20:17 ` Alan Mackenzie
2019-12-06 8:06 ` Eli Zaretskii [this message]
2019-12-06 18:28 ` Alan Mackenzie
2019-12-06 18:48 ` Eli Zaretskii
2019-12-06 22:24 ` Alan Mackenzie
2019-12-07 8:21 ` Eli Zaretskii
2019-12-07 11:40 ` Alan Mackenzie
2019-12-07 13:27 ` Eli Zaretskii
2019-12-07 19:03 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eexhho8o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=38406@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=yyoncho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.