From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38457: 27.0.50; dabbrev-expand regression due to message change Date: Tue, 10 Dec 2019 19:49:00 +0200 Message-ID: <83eexcax6b.fsf@gnu.org> References: <8736e3vve8.fsf@gmx.net> <8736e2coyv.fsf@mail.linkov.net> <83y2vujd0y.fsf@gnu.org> <87blspm0sm.fsf@mail.linkov.net> <837e3ckbem.fsf@gnu.org> <871rtjn0kt.fsf@mail.linkov.net> <83lfrrigj8.fsf@gnu.org> <87eexiqps5.fsf@mail.linkov.net> <83lfrphp94.fsf@gnu.org> <87wob7g2jk.fsf@mail.linkov.net> <83k177ebs0.fsf@gnu.org> <87muc27prn.fsf@mail.linkov.net> <83tv6acgq5.fsf@gnu.org> <87eexdoygh.fsf@mail.linkov.net> <83tv68c0nb.fsf@gnu.org> <83h828b0lz.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135504"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38457@debbugs.gnu.org, juri@linkov.net To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 10 18:50:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iejeF-000Z5V-Mv for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Dec 2019 18:50:11 +0100 Original-Received: from localhost ([::1]:60530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iejeE-000678-Es for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Dec 2019 12:50:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48867) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieje7-00064o-2x for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2019 12:50:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieje6-0004xH-48 for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2019 12:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50581) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieje6-0004xB-09 for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2019 12:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ieje5-0002IV-Td for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2019 12:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2019 17:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38457 X-GNU-PR-Package: emacs Original-Received: via spool by 38457-submit@debbugs.gnu.org id=B38457.15760001618782 (code B ref 38457); Tue, 10 Dec 2019 17:50:01 +0000 Original-Received: (at 38457) by debbugs.gnu.org; 10 Dec 2019 17:49:21 +0000 Original-Received: from localhost ([127.0.0.1]:56554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iejdQ-0002HZ-QA for submit@debbugs.gnu.org; Tue, 10 Dec 2019 12:49:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iejdO-0002HM-M0 for 38457@debbugs.gnu.org; Tue, 10 Dec 2019 12:49:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iejdJ-0004ls-9t; Tue, 10 Dec 2019 12:49:13 -0500 Original-Received: from [176.228.60.248] (port=2558 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iejdI-0001pJ-Gd; Tue, 10 Dec 2019 12:49:13 -0500 In-reply-to: (message from Stefan Monnier on Tue, 10 Dec 2019 12:08:14 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173148 Archived-At: > From: Stefan Monnier > Cc: juri@linkov.net, 38457@debbugs.gnu.org > Date: Tue, 10 Dec 2019 12:08:14 -0500 > > [ I presume that additionally from inserting the minibuffer's contents > we'd add some delimiters to clearly separate the message from the > minibuffer's contents. ] Something like minibuffer-message's "[..]", perhaps? > I guess there could be some visible artifacts of this subterfuge in the > case where the minibuffer's content is currently affected by overlays > (since we presumably wouldn't copy those to the echo-area), but I'm not > sure this would be a real problem. We could copy the overlays, if that's important. > Another issue could be when the minibuffer is large, in which case we'll > want to try and preserve the window-start but also we'll want to make > sure the new message is visible. You mean, if resize-mini-windows is nil? Otherwise, I see no problem. If resize-mini-windows is nil, the result will be the same as with the current code, which calls minibuffer-message: the message is partially or completely invisible. > BTW, we should probably think about replacing `message` with something > that lets the caller give more information about the intended behavior > (e.g. to also solve the issue of several successive calls to message > resulting in the user only seeing the last message). Of course, this > would be for Emacs-28. Right.