From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40119: [PATCH] Make compilation-mode regexp matching case-sensitive Date: Wed, 18 Mar 2020 20:05:07 +0200 Message-ID: <83eetpfsj0.fsf@gnu.org> References: <837B3AF9-46ED-415A-BDFE-251BD97ECBB8@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="39925"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40119@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 18 19:06:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jEd57-000AHa-6i for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Mar 2020 19:06:17 +0100 Original-Received: from localhost ([::1]:56914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEd56-0003uk-8M for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Mar 2020 14:06:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58421) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEd4u-0003uP-Ch for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 14:06:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEd4t-0001ht-BA for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 14:06:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35382) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEd4t-0001gV-4p for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 14:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jEd4r-0002R8-W3 for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 14:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Mar 2020 18:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40119 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40119-submit@debbugs.gnu.org id=B40119.15845547319322 (code B ref 40119); Wed, 18 Mar 2020 18:06:01 +0000 Original-Received: (at 40119) by debbugs.gnu.org; 18 Mar 2020 18:05:31 +0000 Original-Received: from localhost ([127.0.0.1]:41355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEd4M-0002QI-O5 for submit@debbugs.gnu.org; Wed, 18 Mar 2020 14:05:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEd4L-0002Q6-G7 for 40119@debbugs.gnu.org; Wed, 18 Mar 2020 14:05:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jEd4F-0000He-Tx; Wed, 18 Mar 2020 14:05:24 -0400 Original-Received: from [176.228.60.248] (port=2507 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jEd4D-0007Mw-2G; Wed, 18 Mar 2020 14:05:23 -0400 In-Reply-To: <837B3AF9-46ED-415A-BDFE-251BD97ECBB8@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 18 Mar 2020 16:31:49 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177509 Archived-At: > From: Mattias Engdegård > Date: Wed, 18 Mar 2020 16:31:49 +0100 > > +** Compilation mode > + > +*** Regexp matching of messages is now case-sensitive. > + > > * New Modes and Packages in Emacs 28.1 > > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index 455f181f50..aefaa1707a 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -1435,7 +1435,8 @@ compilation-parse-errors > (if (symbolp item) > (setq item (cdr (assq item > compilation-error-regexp-alist-alist)))) > - (let ((file (nth 1 item)) > + (let ((case-fold-search nil) > + (file (nth 1 item)) > (line (nth 2 item)) > (col (nth 3 item)) > (type (nth 4 item)) What if we are wrong and some compiler needs case-insensitive matching? Your change makes it impossible to get back the old behavior, not even optionally. Thanks.