all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 40119@debbugs.gnu.org
Subject: bug#40119: [PATCH] Make compilation-mode regexp matching case-sensitive
Date: Wed, 18 Mar 2020 20:05:07 +0200	[thread overview]
Message-ID: <83eetpfsj0.fsf@gnu.org> (raw)
In-Reply-To: <837B3AF9-46ED-415A-BDFE-251BD97ECBB8@acm.org> (message from Mattias Engdegård on Wed, 18 Mar 2020 16:31:49 +0100)

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Wed, 18 Mar 2020 16:31:49 +0100
> 
> +** Compilation mode
> +
> +*** Regexp matching of messages is now case-sensitive.
> +
>  \f
>  * New Modes and Packages in Emacs 28.1
>  
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index 455f181f50..aefaa1707a 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -1435,7 +1435,8 @@ compilation-parse-errors
>      (if (symbolp item)
>          (setq item (cdr (assq item
>                                compilation-error-regexp-alist-alist))))
> -    (let ((file (nth 1 item))
> +    (let ((case-fold-search nil)
> +          (file (nth 1 item))
>            (line (nth 2 item))
>            (col (nth 3 item))
>            (type (nth 4 item))

What if we are wrong and some compiler needs case-insensitive
matching?  Your change makes it impossible to get back the old
behavior, not even optionally.

Thanks.





  reply	other threads:[~2020-03-18 18:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 15:31 bug#40119: [PATCH] Make compilation-mode regexp matching case-sensitive Mattias Engdegård
2020-03-18 18:05 ` Eli Zaretskii [this message]
2020-03-18 18:30   ` Mattias Engdegård
2020-03-18 19:29     ` Eli Zaretskii
2020-03-18 22:05       ` Mattias Engdegård
2020-03-25 20:41         ` Mattias Engdegård
2020-03-25 20:55       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eetpfsj0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=40119@debbugs.gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.