From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41086: Fwd: bug#41086: [PATCH] Add user-defined column widths to package-list (package.el) Date: Tue, 05 May 2020 17:14:50 +0300 Message-ID: <83eerympt1.fsf@gnu.org> References: <87imhbo1ku.fsf@stefankangas.se> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18118"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41086@debbugs.gnu.org To: Stefan Kangas , Chris McMahan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 05 16:16:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVyMn-0004WN-3s for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 16:16:13 +0200 Original-Received: from localhost ([::1]:40654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVyMm-0006ym-2l for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 10:16:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVyMc-0006yc-LY for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 10:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVyMc-0004UH-Ca for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 10:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVyMc-0008Hs-9A for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 10:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 May 2020 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41086 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41086-submit@debbugs.gnu.org id=B41086.158868811831790 (code B ref 41086); Tue, 05 May 2020 14:16:02 +0000 Original-Received: (at 41086) by debbugs.gnu.org; 5 May 2020 14:15:18 +0000 Original-Received: from localhost ([127.0.0.1]:36968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVyLu-0008Gg-1J for submit@debbugs.gnu.org; Tue, 05 May 2020 10:15:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVyLs-0008GQ-Mf for 41086@debbugs.gnu.org; Tue, 05 May 2020 10:15:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55079) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVyLn-0002jv-FQ; Tue, 05 May 2020 10:15:11 -0400 Original-Received: from [176.228.60.248] (port=4053 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jVyLm-0006Rg-UZ; Tue, 05 May 2020 10:15:11 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 5 May 2020 03:39:09 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179732 Archived-At: > From: Stefan Kangas > Date: Tue, 5 May 2020 03:39:09 +0200 > > The changelog entry follows: > > * package.el (package-menu-mode): User can now adjust the column widths of > the package menu by setting the values of the following defcustoms. > > (package-name-column-width) New defcustom > (package-version-column-width) New defcustom > (package-status-column-width) New defcustom Our style is slightly different, see CONTRIBUTE. (Emacs actually has commands that will help you format these log entries.) It should look like this in this case: Let user adjust the column widths of the package menu. * lisp/emacs-lisp/package.el (package-name-column-width) (package-version-column-width, package-status-column-width): New defcustoms. (package-menu-mode): Use the values of defcustoms instead of hardcoded values. (Bug#41086) > +(defcustom package-name-column-width 30 > + "Column width for the Package name in the package menu." > + :type 'number > + :version "28.1") > + > +(defcustom package-version-column-width 14 > + "Column width for the Package version in the package menu." > + :type 'number > + :version "28.1") > + > +(defcustom package-status-column-width 12 > + "Column width for the Package status in the package menu." > + :type 'number > + :version "28.1") These change the default values from the current hard-coded ones. Any reasons for that change? > (setq tabulated-list-format > - `[("Package" 18 package-menu--name-predicate) > - ("Version" 13 package-menu--version-predicate) > - ("Status" 10 package-menu--status-predicate) > + `[("Package" ,package-name-column-width package-menu--name-predicate) > + ("Version" ,package-version-column-width package-menu--version-predicate) > + ("Status" ,package-status-column-width package-menu--status-predicate) > ,@(if (cdr package-archives) > '(("Archive" 10 package-menu--archive-predicate))) Why do we leave the "Archive" column width hard-coded? Also, I see 13 in at least 2 more places in the code, are they related? If so, they should be changed to use the defcustom as well. Finally, I think this warrants a NEWS entry. Thanks.