From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] [WIP] Port feature/native-comp to Windows.
Date: Tue, 12 May 2020 19:56:55 +0300
Message-ID: <83eerp852g.fsf@gnu.org>
References: <5eb5b953.1c69fb81.a67ce.a764@mx.google.com>
 <83lfm1hc91.fsf@gnu.org>
 <CAFnS-O=AAuEkA8o+Kf3KXJ1FRQDX6OzoO_P0fLCvUaOUcw3UNw@mail.gmail.com>
 <83wo5lds87.fsf@gnu.org>
 <CAFnS-OmGJ1S17g9T0uMR_D3z3Q-dZ1w-E-09d+4LfaD_VLFcGg@mail.gmail.com>
 <83lflzd8es.fsf@gnu.org>
 <CAFnS-Om0mvw-iVhoYX_5tQDKEGU+tC9WyWdijpM5ePecDvRTPw@mail.gmail.com>
 <83ftc7d4zu.fsf@gnu.org>
 <CAFnS-OkBNSiD_VtUjtPcL0063K+0-gf9qZ2-EtRjeq=RtKf_Qg@mail.gmail.com>
 <83blmvd2if.fsf@gnu.org>
 <CAFnS-OkGgMV-c+jrFArdY4M-Kroxnv3RVAQ9dXcZmKnxsA+DVw@mail.gmail.com>
 <833686d08r.fsf@gnu.org>
 <CAFnS-OkT=x1Ni8jwVRJRWVTRYVEKgK1uqpePws2G2HzTgAPf9A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
	logging-data="64337"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org, akrl@sdf.org
To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= <nicolasbertolo@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 12 19:06:29 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jYYMO-000GXL-Fq
	for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 19:06:28 +0200
Original-Received: from localhost ([::1]:40650 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jYYMN-00064m-F2
	for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 13:06:27 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53396)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1jYYDW-0006cE-Mj
 for emacs-devel@gnu.org; Tue, 12 May 2020 12:57:18 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45220)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jYYDW-00038T-73; Tue, 12 May 2020 12:57:18 -0400
Original-Received: from [176.228.60.248] (port=3180 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jYYDT-0005p4-Cw; Tue, 12 May 2020 12:57:16 -0400
In-Reply-To: <CAFnS-OkT=x1Ni8jwVRJRWVTRYVEKgK1uqpePws2G2HzTgAPf9A@mail.gmail.com>
 (message from Nicolas =?utf-8?Q?B=C3=A9rtolo?= on Mon, 11 May 2020 23:46:09
 -0300)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:249994
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/249994>

> From: Nicolas Bértolo <nicolasbertolo@gmail.com>
> Date: Mon, 11 May 2020 23:46:09 -0300
> Cc: Andrea Corallo <akrl@sdf.org>, emacs-devel@gnu.org
> 
> The attached patch does implement dynamic loading of libgccjit in Windows.

Thanks.

> -    LIBGCCJIT_LIB="-lgccjit -ldl"
> +    # mingw32 loads the library dynamically.
> +    if test "${opsys}" != "mingw32"; then
> +      LIBGCCJIT_LIB="-lgccjit -ldl"

libdl exists only in MinGW64, I think.

Why do you need it? is it because the code uses dlopen/dlsym
somewhere?

> +/* In alphabetical order */
> +#define gcc_jit_block_add_assignment fn_gcc_jit_block_add_assignment
> +#define gcc_jit_block_add_comment fn_gcc_jit_block_add_comment
> +#define gcc_jit_block_add_eval fn_gcc_jit_block_add_eval
> +#define gcc_jit_block_end_with_conditional fn_gcc_jit_block_end_with_conditional

I think it's good to #undef each symbol before defining it.