From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41619: [PATCH] Mark python-shell-virtualenv-root as safe local variable Date: Sat, 13 Jun 2020 10:42:57 +0300 Message-ID: <83eeqj4dj2.fsf@gnu.org> References: <87367htbaq.fsf@warpmail.net> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="116264"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41619-done@debbugs.gnu.org To: "Philip K." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 13 09:44:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jk0pn-000UAQ-70 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jun 2020 09:44:11 +0200 Original-Received: from localhost ([::1]:35714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk0pm-0003zJ-6y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jun 2020 03:44:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk0pe-0003rf-Nm for bug-gnu-emacs@gnu.org; Sat, 13 Jun 2020 03:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jk0pe-0004d2-Ez for bug-gnu-emacs@gnu.org; Sat, 13 Jun 2020 03:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jk0pe-0006oq-Dk for bug-gnu-emacs@gnu.org; Sat, 13 Jun 2020 03:44:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jun 2020 07:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 41619@debbugs.gnu.org, eliz@gnu.org, philip.kaludercic@fau.de Original-Received: via spool by 41619-done@debbugs.gnu.org id=D41619.159203419726149 (code D ref 41619); Sat, 13 Jun 2020 07:44:02 +0000 Original-Received: (at 41619-done) by debbugs.gnu.org; 13 Jun 2020 07:43:17 +0000 Original-Received: from localhost ([127.0.0.1]:40802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk0ov-0006nh-7P for submit@debbugs.gnu.org; Sat, 13 Jun 2020 03:43:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk0ot-0006nS-B3 for 41619-done@debbugs.gnu.org; Sat, 13 Jun 2020 03:43:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54191) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk0ol-0004Yl-NL; Sat, 13 Jun 2020 03:43:07 -0400 Original-Received: from [176.228.60.248] (port=4026 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jk0ol-0004Pe-3G; Sat, 13 Jun 2020 03:43:07 -0400 In-Reply-To: <87367htbaq.fsf@warpmail.net> (philip.kaludercic@fau.de) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181904 Archived-At: > From: "Philip K." > Date: Sat, 30 May 2020 22:31:09 +0200 > > I was trying to work with python today and it required me to use a > virtual environment. I noticed that python-mode already had some basic > virtualenv facilites, and it all worked. The only thing that annoyed me > was that I couldn't configure the setup to be properly persistent, since > python-shell-virtualenv-root couldn't be set as a directory local > variable. > > The commentary section mentions > > > ;; (setq python-shell-virtualenv-root "/path/to/env/") > > but I couldn't find any other details on how the mode expects me to set > the variable. > > Therefore I patched the few lines, and it works great. Thanks, installed on the master branch. In the future please accompany your changes with a ChangeLog-style commit log entry; see CONTRIBUTE for the details. (I added that for you in this case.)