From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43837: 28.0.50; [NS] Internal border of inactive frame loses color Date: Wed, 07 Oct 2020 10:19:35 +0300 Message-ID: <83eemaa4fs.fsf@gnu.org> References: <20201006203715.GD60347@breton.holly.idiocy.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39791"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43837@debbugs.gnu.org, andreyk.mad@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 07 09:20:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQ3kG-000AFL-LP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 09:20:16 +0200 Original-Received: from localhost ([::1]:55732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ3kF-0003lR-7H for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 03:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ3k2-0003l6-99 for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 03:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43428) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQ3k1-0000nX-WA for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 03:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQ3k1-0004JT-Ru for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 03:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Oct 2020 07:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43837 X-GNU-PR-Package: emacs Original-Received: via spool by 43837-submit@debbugs.gnu.org id=B43837.160205517816545 (code B ref 43837); Wed, 07 Oct 2020 07:20:01 +0000 Original-Received: (at 43837) by debbugs.gnu.org; 7 Oct 2020 07:19:38 +0000 Original-Received: from localhost ([127.0.0.1]:54974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ3je-0004In-LK for submit@debbugs.gnu.org; Wed, 07 Oct 2020 03:19:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ3jc-0004IZ-Dz for 43837@debbugs.gnu.org; Wed, 07 Oct 2020 03:19:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40927) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ3jW-0000ml-Lq; Wed, 07 Oct 2020 03:19:30 -0400 Original-Received: from [176.228.60.248] (port=3215 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kQ3jV-0002tS-UM; Wed, 07 Oct 2020 03:19:30 -0400 In-Reply-To: <20201006203715.GD60347@breton.holly.idiocy.org> (message from Alan Third on Tue, 6 Oct 2020 21:37:15 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189987 Archived-At: > Date: Tue, 6 Oct 2020 21:37:15 +0100 > From: Alan Third > Cc: 43837@debbugs.gnu.org > > > 1. M-: (setq test-frame (make-frame '((left . 50) (top . 50)))) > > 2. C-x 5 o > > 3. M-: (set-face-background 'internal-border "blue" test-frame) > > 4. M-: (modify-frame-parameters test-frame '((background-color . "black"))) > > > > Now (face-background 'internal-border test-frame) returns nil. > > If we skip step 2, then the internal border color remains. > > This isn't an NS specific problem. Eli actually spotted the bug last > year and put in a FIXME. It was me? > I can't think of a good reason for the code to use the selected frame, > but perhaps I'm missing something. Heh, I went through the rabbit hole and arrived at the same fix, now installed on master. Let's see what will it break, and then perhaps we will understand why the old code used selected-frame there... Thanks.