From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: New multi-command facility displays in the wrong echo area. Date: Fri, 16 Oct 2020 10:19:49 +0300 Message-ID: <83eelywsbu.fsf@gnu.org> References: <20201009163445.GB4027@ACM> <20201009203810.GC4027@ACM> <83imbi609a.fsf@gnu.org> <20201010103233.GB5662@ACM> <834kn25o6b.fsf@gnu.org> <20201010124446.GC5662@ACM> <831ri65jpc.fsf@gnu.org> <83zh4u44mx.fsf@gnu.org> <83imbg4yl3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9416"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ghe@sdf.org, acm@muc.de, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 16 09:21:52 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTK3k-0002MG-Eb for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Oct 2020 09:21:52 +0200 Original-Received: from localhost ([::1]:36180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTK3j-0007P7-H2 for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Oct 2020 03:21:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTK1o-0006AW-Rc for emacs-devel@gnu.org; Fri, 16 Oct 2020 03:19:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42264) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTK1o-0001r8-Hw; Fri, 16 Oct 2020 03:19:52 -0400 Original-Received: from [176.228.60.248] (port=2949 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kTK1n-0006jO-FY; Fri, 16 Oct 2020 03:19:51 -0400 In-Reply-To: (message from Stefan Monnier on Wed, 14 Oct 2020 18:51:09 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257782 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , acm@muc.de, emacs-devel@gnu.org > Date: Wed, 14 Oct 2020 18:51:09 -0400 > > > (or (eq (window-frame) (window-frame (active-minibuffer-window))) > > (eq (frame-parameter (window-frame (active-minibuffer-window)) 'minibuffer) 'only))) > > I think it would be cleaner (i.e. better express the intent) if it was > written something like > > (eq (mini-window-of (selected-frame)) > (active-minibuffer-window)) > > which may require writing `mini-window-of` first (and choosing a better > name for it along the way). Yes, I've used let* to avoid calling active-minibuffer-window (and other functions) more than once.