From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Two fixes for module bug when interleaving threads Date: Sat, 28 Nov 2020 09:25:04 +0200 Message-ID: <83eekendtb.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17608"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 28 08:26:06 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiucP-0004T6-8j for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Nov 2020 08:26:05 +0100 Original-Received: from localhost ([::1]:60116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiucO-0005BH-B5 for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Nov 2020 02:26:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiubi-0004jR-1W for emacs-devel@gnu.org; Sat, 28 Nov 2020 02:25:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41367) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiubh-0004CC-Qb; Sat, 28 Nov 2020 02:25:21 -0500 Original-Received: from [176.228.60.248] (port=4215 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kiube-0004IG-9G; Sat, 28 Nov 2020 02:25:19 -0500 In-Reply-To: (message from Philipp Stephani on Fri, 27 Nov 2020 21:57:41 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259936 Archived-At: > From: Philipp Stephani > Date: Fri, 27 Nov 2020 21:57:41 +0100 > > I just pushed two fixes for the same bug that appears when > interleaving module calls in separate threads: > cdc632fbe6e149318147a98cccf1b7af191f2ce8 for the release branch and > 23974cfa48b9245658667eff81d132b3aecd2618 for master. The intention was > that a simpler and more localized fix should go to the release branch, > the "proper" fix to master. Now I've realized that arguably the > simpler fix is overall better: it's more localized, touches fewer > moving pieces, and is probably not significantly slower (though I > haven't benchmarked it). Any opinions? If people agree, we can > overwrite the fix on master with the fix on the release branch. Thanks, but the changes are too significant to go to the release branch before they are properly tested on master. With the start of Emacs 27.2 pretest imminent, I feel it's unsafe to make such changes there. So I've reverted the commit on the release branch. We can revisit this for Emacs 27.3, or if the pretest of Emacs 27.2 takes longer than I expect.