From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: A tip: how to display longer function names in profiler-report
Date: Mon, 21 Dec 2020 19:15:42 +0200
Message-ID: <83eejjrsg1.fsf@gnu.org>
References: <X+DOFUUaJoBM2jzo@ACM>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="9276"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Alan Mackenzie <acm@muc.de>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 21 18:16:32 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1krOnP-0002J9-Ta
	for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Dec 2020 18:16:31 +0100
Original-Received: from localhost ([::1]:40474 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1krOnO-0000b2-V4
	for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Dec 2020 12:16:30 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50440)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1krOms-0008Uu-I5
 for emacs-devel@gnu.org; Mon, 21 Dec 2020 12:15:58 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41540)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1krOms-00008G-7Y; Mon, 21 Dec 2020 12:15:58 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3209
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1krOmr-0008AW-FL; Mon, 21 Dec 2020 12:15:58 -0500
In-Reply-To: <X+DOFUUaJoBM2jzo@ACM> (message from Alan Mackenzie on Mon, 21
 Dec 2020 16:32:21 +0000)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:261391
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/261391>

> Date: Mon, 21 Dec 2020 16:32:21 +0000
> From: Alan Mackenzie <acm@muc.de>
> 
> The variable which controls the widths of the comment name, number of
> samples, and percentage columns is profiler-report-cpu-line-format.
> It's default value is:
> 
>     ((50 left) (24 right
>                ((19 right) (5 right))))
> 
> , which codes column sizes of 50, 19, and 5.  The 5 (for percentage) is
> OK.  50 (defun name) is too small.  19 (number of samples) is too big -
> that is broad enough to count up to 10^16 seconds, of the order of the
> age of the universe.

Isn't it also used for the "memory" profile?  in that case the numbers
are much larger in magnitude.  So perhaps we should use 2 different
values for that variable (and I wouldn't worry about the one used for
"memory" profile, since it shouldn't be used on any modern platform).