From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Date: Sat, 17 Apr 2021 15:27:58 +0300 Message-ID: <83eef9w0xd.fsf@gnu.org> References: <7dee3f4235cf450a3254@heytings.org> <83mttxwgm8.fsf@gnu.org> <1869622e16688e6aedec@heytings.org> <83h7k5w54l.fsf@gnu.org> <83fszpw40t.fsf@gnu.org> <1869622e16c60dc2ce0d@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12596"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47832@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 17 14:29:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXk4x-00038J-U4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 14:29:39 +0200 Original-Received: from localhost ([::1]:54094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXk4w-0002N5-Vc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 08:29:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXk4M-0002Ll-4v for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 08:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXk4L-0006lo-UQ for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 08:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXk4L-0006hJ-Qx for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 08:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Apr 2021 12:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47832 X-GNU-PR-Package: emacs Original-Received: via spool by 47832-submit@debbugs.gnu.org id=B47832.161866250125664 (code B ref 47832); Sat, 17 Apr 2021 12:29:01 +0000 Original-Received: (at 47832) by debbugs.gnu.org; 17 Apr 2021 12:28:21 +0000 Original-Received: from localhost ([127.0.0.1]:42433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXk3g-0006fs-Py for submit@debbugs.gnu.org; Sat, 17 Apr 2021 08:28:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXk3e-0006fd-Qg for 47832@debbugs.gnu.org; Sat, 17 Apr 2021 08:28:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60943) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXk3Y-0006Gf-4W; Sat, 17 Apr 2021 08:28:12 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4802 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lXk3N-0005Oy-TH; Sat, 17 Apr 2021 08:28:06 -0400 In-Reply-To: <1869622e16c60dc2ce0d@heytings.org> (message from Gregory Heytings on Sat, 17 Apr 2021 11:32:25 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204193 Archived-At: > Date: Sat, 17 Apr 2021 11:32:25 +0000 > From: Gregory Heytings > cc: 47832@debbugs.gnu.org > > > Since gui_init_fringe returns immediately if the frame interface doesn't > > provide a method for fringe initialization, I think we should call > > gui_init_fringe unconditionally on X. Here I meant to call gui_init_fringe unconditionally. It will make the code less confusing. > > And in any case, the patch for gui_init_fringe is sub-optimal: it > > unnecessarily loops over the standard bitmaps that were superseded. It > > is better to leave the first loop go over the standard bitmaps, whether > > superseded or not, and the second loop go over non-standard bitmaps > > only. > > It is not sub-optimal, rif->define_fringe_bitmap will only be called for > those standard bitmaps that were superseded. For the non-superseded ones, > fringe_bitmaps[bt] is NULL. I meant the first loop, not the second one.