From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position. Date: Fri, 21 May 2021 08:46:45 +0300 Message-ID: <83eee0ocze.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31847"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 22763@debbugs.gnu.org To: Ben Levy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 21 07:48:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljy1B-00089U-Qe for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 May 2021 07:48:17 +0200 Original-Received: from localhost ([::1]:45600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljy1A-0008Mp-36 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 May 2021 01:48:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljy0z-0008MR-T7 for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 01:48:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljy0w-0004BR-Ba for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 01:48:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljy0w-0001zY-8v for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 01:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 May 2021 05:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22763-submit@debbugs.gnu.org id=B22763.16215760267579 (code B ref 22763); Fri, 21 May 2021 05:48:02 +0000 Original-Received: (at 22763) by debbugs.gnu.org; 21 May 2021 05:47:06 +0000 Original-Received: from localhost ([127.0.0.1]:35570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljy01-0001yB-Qc for submit@debbugs.gnu.org; Fri, 21 May 2021 01:47:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljxzy-0001xc-OK for 22763@debbugs.gnu.org; Fri, 21 May 2021 01:47:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32808) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljxzo-0003RW-0x; Fri, 21 May 2021 01:46:55 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4534 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljxzl-0007IA-1H; Fri, 21 May 2021 01:46:51 -0400 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206974 Archived-At: > Date: Thu, 20 May 2021 20:40:31 +0000 > From: Ben Levy via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > (with-temp-buffer > (insert "foo\nbar\nbaz") > (narrow-to-region 4 5) > (message "%s" (line-number-at-pos 1 t))) > > On the latest master (ef7a6eec20), this errors with > > Args out of range: 1, 4, 5 > > But on emacs-27.2, it prints "1". This is the expected behavior: the POSITION argument must be in the accessible portion of the buffer, like every position argument in Emacs. A Lisp program which calls this function like above has a bug that needs to be fixed. This is not a bug. > >From what I can tell, this is because the lisp version of line-number-at-pos > allowed the argument to be outside the visible range, and it widened before > counting lines to allow this. Right, the Lisp implementation was incorrect, and failed to do the test before widening.