From: Eli Zaretskii <eliz@gnu.org>
To: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
Cc: 49782@debbugs.gnu.org
Subject: bug#49782: 28.0.50; set-fontset-font crashes in init (server)
Date: Fri, 30 Jul 2021 17:10:38 +0300 [thread overview]
Message-ID: <83eebfrixt.fsf@gnu.org> (raw)
In-Reply-To: <87mtq4rmh0.fsf@arrian.i-did-not-set--mail-host-address--so-tickle-me> (message from Benjamin Riefenstahl on Fri, 30 Jul 2021 14:54:19 +0200)
> From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
> Date: Fri, 30 Jul 2021 14:54:19 +0200
>
> I have a font initialization in my init file. Reduced to a minimum
> example it does stuff like this:
>
> (mapc
> (lambda (frame)
> (set-fontset-font nil ?a "sans-serif" frame))
> (frame-list))
>
> This crashes when called from "emacsclient -a '' -c".
>
> As a recipe:
>
> * mkdir /tmp/test
> * Copy the above code into /tmp/test/.emacs
> * Run HOME=/tmp/test emacsclient -a '' -c
>
> Note that "emacsclient -a emacs -c" does not crash. There is something
> different between "-a ''" and "-a something".
>
> Running gdb on the corresponding core file I get the typescript below.
> The problem seems to be in gdb frame #7, where even though there is a
> frame reported by frame-list, it does not have a valid fontset and so an
> assertion in FRAME_FONTSET(f) fails.
Probably because it's a daemon frame, which is not a GUI frame.
> I assume this is not intentional, otherwise how do I prevent the crash?
Put this code in server-after-make-frame-hook, I guess.
Does the patch below prevent the crash?
diff --git a/src/fontset.c b/src/fontset.c
index 332be6c..52c7e38 100644
--- a/src/fontset.c
+++ b/src/fontset.c
@@ -1356,6 +1356,9 @@ check_fontset_name (Lisp_Object name, Lisp_Object *frame)
int id;
struct frame *f = decode_live_frame (*frame);
+ if (!FRAME_WINDOW_P (f))
+ error ("Can't use fontsets in non-GUI frames");
+
XSETFRAME (*frame, f);
if (EQ (name, Qt))
next prev parent reply other threads:[~2021-07-30 14:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 12:54 bug#49782: 28.0.50; set-fontset-font crashes in init (server) Benjamin Riefenstahl
2021-07-30 14:05 ` Benjamin Riefenstahl
2021-07-30 14:10 ` Eli Zaretskii [this message]
2021-07-30 17:50 ` Benjamin Riefenstahl
2021-07-30 18:19 ` Eli Zaretskii
2021-07-30 18:35 ` Benjamin Riefenstahl
2021-07-30 18:52 ` Eli Zaretskii
2021-07-30 19:26 ` Benjamin Riefenstahl
2021-07-30 20:02 ` Eli Zaretskii
2021-07-30 20:12 ` Eli Zaretskii
2021-07-31 6:29 ` Eli Zaretskii
2021-07-31 13:05 ` Benjamin Riefenstahl
2021-07-31 13:23 ` Eli Zaretskii
2021-07-30 20:07 ` Lars Ingebrigtsen
2021-07-30 20:09 ` Lars Ingebrigtsen
2021-07-31 12:57 ` Benjamin Riefenstahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eebfrixt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49782@debbugs.gnu.org \
--cc=b.riefenstahl@turtle-trading.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.