From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Tue, 26 Oct 2021 16:04:33 +0300 Message-ID: <83ee88ym1q.fsf@gnu.org> References: <87mtn5fc9s.fsf@gnus.org> <83bl3lchrp.fsf@gnu.org> <87ee8hfajg.fsf@gnus.org> <838rypc98p.fsf@gnu.org> <87h7ddc8iy.fsf@gnus.org> <831r4hc7ta.fsf@gnu.org> <878rypc7e8.fsf@gnus.org> <83zgr5asej.fsf@gnu.org> <8735oxc51n.fsf@gnus.org> <83wnm8c3v3.fsf@gnu.org> <87tuhcc1u1.fsf@gnus.org> <83tuhcaqad.fsf@gnu.org> <881r4fq5b8.fsf@fencepost.gnu.org> <87tuh5z22g.fsf@gnus.org> <83r1c91bu1.fsf@gnu.org> <878ryhz1cb.fsf@gnus.org> <83o87d1acw.fsf@gnu.org> <87h7d5xl8o.fsf@gnus.org> <83lf2h19cn.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6075"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rgm@gnu.org, larsi@gnus.org, 50752@debbugs.gnu.org, shuguang79@qq.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 26 15:08:05 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfMBP-0001J4-In for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 15:08:03 +0200 Original-Received: from localhost ([::1]:46406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfMBO-0000Ku-05 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 09:08:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfM8V-00064C-4q for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 09:05:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfM8U-0007sn-Pw for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 09:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfM8U-0006yz-Es for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 09:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Oct 2021 13:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.163525349326821 (code B ref 50752); Tue, 26 Oct 2021 13:05:02 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 26 Oct 2021 13:04:53 +0000 Original-Received: from localhost ([127.0.0.1]:45416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfM8L-0006yW-5p for submit@debbugs.gnu.org; Tue, 26 Oct 2021 09:04:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfM8G-0006yG-Nh for 50752@debbugs.gnu.org; Tue, 26 Oct 2021 09:04:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfM87-0007pm-Et; Tue, 26 Oct 2021 09:04:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OXv3L7gQelNba/Zvdy75yaImvnpY+l3SdQ/wsSc+VAc=; b=q2f8jTYYNdi8 7BJBp6Ftcfw5hwRN+2YRPMHKccLUvpaii1XSYMQgnIGwV7gKBUabEJamuWs/zW3ckDINJpEfxo8Ky iG5AoEnNVI+pxN8r2m3RjpqTOjfK0LnLATczhqU5ShuBfnJ/d615mgMO+Z/OmZHjrMmaozcVQ/PkJ 6ZZd96J3G5gImDenxAkGsgRwYcCLFWbklMaVZF+M4STecQB2okfQSoguQzMF1kUIOWNXAVRAqyNUy AJiGBkT0I/RgD3194pWsrLA+sHPFa3Mm5cPUzEE6TALB3Tv1Wiz3AarKn5s2i8+baMX+4WPVrTZmx NJhM65SBgfoYTh9cOI7yfA==; Original-Received: from [87.69.77.57] (port=4549 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfM86-0001EQ-Sn; Tue, 26 Oct 2021 09:04:39 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 26 Oct 2021 01:38:32 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218382 Archived-At: > From: Stefan Kangas > Date: Tue, 26 Oct 2021 01:38:32 -0700 > Cc: rgm@gnu.org, 50752@debbugs.gnu.org, shuguang79@qq.com > > Eli Zaretskii writes: > > >> I think just downcasing ASCII would get use more than 99%, really. > > > > Then let's go with this variant on emacs-28, and leave the full > > solution for master. > > OK. I'm not sure if you just mean my previous patch, but without Lars' > fixes for the Turkish language environment, or if you mean a stripped > down version of my patch. Unfortunately, I meant neither of these two, because they both are quite non-trivial. I meant a much simpler patch which only downcases ASCII letters, and that's all. Such a change doesn't need to call Fdowncase, and definitely doesn't need to futz with multibyte characters. It should be a simple copy and a single loop downcasing the characters. (The NEWS entry for emacs-28 should thus say that we only handle this simple class of problems.) The log message should say "don't merge to master". Sorry for not expressing myself clearly enough.