From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: etags name collision. Date: Mon, 11 Apr 2022 19:40:29 +0300 Message-ID: <83ee2360aq.fsf@gnu.org> References: <20220411124736.3qijvtearh6wlen7.ref@Ergus> <20220411124736.3qijvtearh6wlen7@Ergus> <83pmln69n0.fsf@gnu.org> <20220411134749.ps6g5ulpbamzm6ot@Ergus> <83k0bv679q.fsf@gnu.org> <20220411154635.qfw2ijpdahiv5ctl@Ergus> <83fsmj62jl.fsf@gnu.org> <20220411161942.xsqr3ekorpm6jf6y@Ergus> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 11 18:56:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndxKe-00076b-T5 for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 18:56:05 +0200 Original-Received: from localhost ([::1]:42582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndxKd-00048R-BU for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 12:56:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndx5f-0005D6-Iq for emacs-devel@gnu.org; Mon, 11 Apr 2022 12:40:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndx5f-0001mA-0Q; Mon, 11 Apr 2022 12:40:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8QwQYQcJW6C545XocYM1MRIL8vCiZ+wro3aYJu0ygIE=; b=A/ufl8oan4nT q7yE+yGN0g3ANGlAbzmfo8zEt32yoGGd+7CeZfklvZddFy1+InZ2YLf0lWGUME1ZrTej7pUKfu/Fo gyDzpCSBWV0vll2Qt/LMVq6DNhaw5RZXRs8O8tSJAKciTswhesYfG8h1r309orRItvGsC+4AxFFfd E7pdLXFdYmvQbHta0O2bO4izwM0O8F8yYtp9XplRy5aIn8aZFLJ9iLAK5VusY2kVSpx0LON+tMIbT iWw5jRj0mFYVOU0R+8PZhp0pzvGgWsiWpaV3yDw1dnw4RLb2UjtRAUztQeKdrgSHVpBj7ZPrdawBH l2u9GrZttqOw/WL584AB0g==; Original-Received: from [87.69.77.57] (port=1745 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndx5d-0007cs-Mr; Mon, 11 Apr 2022 12:40:34 -0400 In-Reply-To: <20220411161942.xsqr3ekorpm6jf6y@Ergus> (message from Ergus on Mon, 11 Apr 2022 18:19:42 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288227 Archived-At: > Date: Mon, 11 Apr 2022 18:19:42 +0200 > From: Ergus > Cc: emacs-devel@gnu.org > > On Mon, Apr 11, 2022 at 06:51:58PM +0300, Eli Zaretskii wrote: > > >The code should test whether another version of 'ctags' is already > >installed, and if so, that it isn't our 'ctags'. _Then_ we could > >default to not installing our 'ctags'. Your proposal doesn't make > >that test, so please add it. > > > >Thanks. > > > I do this tests like with mailutils and movemail: > > (ctags --version) >/dev/null 2>&1 || with_ctags=no > > Isn't this enough? No, because AFAIU this test will succeed also if the installed ctags is (an older version) of the program that came with (an older version) of Emacs. You need to make sure the text emitted by --version does NOT include "GNU Emacs".