From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Location of mouse click Date: Fri, 15 Apr 2022 09:23:31 +0300 Message-ID: <83ee1y3lwc.fsf@gnu.org> References: <83bkx53yba.fsf@gnu.org> <838rs93rhl.fsf@gnu.org> <83mtgn36i9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11633"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yasushi SHOJI Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 15 08:24:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nfFNG-0002rw-Lo for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Apr 2022 08:24:06 +0200 Original-Received: from localhost ([::1]:35986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfFNF-0001EC-8c for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Apr 2022 02:24:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfFMW-0000Xn-Sr for emacs-devel@gnu.org; Fri, 15 Apr 2022 02:23:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfFMW-0006j5-Jo; Fri, 15 Apr 2022 02:23:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=w7zVbv7mV0AyfeV909uoiU5Tmdr2zhvf8kvAY1PAV0o=; b=C+FYBVrH7I+IXjGsJX6Y kDcP1v7L09ymasF+9/xzX9eqHp80mV4hCHf2Uw4sX2CGLH1wfC3SYPyANPemS4dqqi91rViPtZtRK 6u91xLHEqCtk9fhU9hZP0SIg39WhaNFzCV5zTgjW8p5LO5N7v71VUfNmx5MzwcrB1smV1IEBS8uFe v9oCZvcrRoKHv01TFxVJ7KQ4M+qOqr1ylTPg0LavTXgtIWz433dRiifgpwkzch1uMzpzHtnHSieMz vx9Oje6suBBe0to35wY50Vj+mAwfKrJZu4+KK/YwjV06sAype39jUo/iNLq7vkquEZLJPzd4l3a5N chcMLbBcyMH4Qw==; Original-Received: from [87.69.77.57] (port=3831 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfFMW-0006PL-1R; Fri, 15 Apr 2022 02:23:20 -0400 In-Reply-To: (message from Yasushi SHOJI on Fri, 15 Apr 2022 14:11:23 +0900) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288422 Archived-At: > From: Yasushi SHOJI > Date: Fri, 15 Apr 2022 14:11:23 +0900 > Cc: emacs-devel@gnu.org > > On Fri, Apr 15, 2022 at 2:43 AM Eli Zaretskii wrote: > > > > 0. emacs -Q > > > > 1. open a.txt > > > > 2. (toggle-truncate-lines) > > > > 3. goto the end of the last line > > > > 4. make the frame narrow so that "あ"s are not shown > > > > 5. click on the last word "dog" > > > > > > > > But, this assumes that Japanese and ASCII chars have different heights. > > > > > > > > > If it is important to click the mouse at specific > > > > > > > > You can click anywhere on the last line. > > > > > > Thanks, I see the problem and will look into it. > > > > I hope I've now fixed this on the master branch. > > Thank you, Eli. The change, 67e7870a, works perfectly. Thanks for testing, and for a clear test case. > Would you mind backporting to 28? I've tested the change > by cherry picking on 28, and it works without a glitch. You are free to use it in your Emacs 28, but I don't consider it safe enough to have this change in Emacs 28.2 for the general consumption. As simple and innocent as the change may look, it was done in a very low-level subroutine, which is used all over the place in display code. I cannot predict what issues it could cause elsewhere, which would require followup changes to unbreak. OTOH, the problem you described exists since Emacs 25.1, so it cannot be too annoying, or we would have heard about it sooner; thus, fixing it is not an urgent enough need, and doesn't outweigh the potential dangers of destabilizing the release branch. Sorry.