From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master c3ab8f1: Improve buffer-match-p documentation Date: Sat, 16 Apr 2022 11:34:10 +0300 Message-ID: <83ee1x1l6l.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 16 10:34:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nfdtP-0004uA-8y for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Apr 2022 10:34:55 +0200 Original-Received: from localhost ([::1]:35642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfdtN-0001Am-Dq for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Apr 2022 04:34:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfdsS-0000Vv-5z for emacs-devel@gnu.org; Sat, 16 Apr 2022 04:33:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfdsR-0006b3-TB; Sat, 16 Apr 2022 04:33:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=Sw+5XDib1PaoDOhTEqU5RcJ0vD4Bskt17Kyy8vfz0m8=; b=AOlMwDrTpGSEAG CHcVKwNmubtALSC6XS1Z3rLzpw445Oh8UI1f9Hcajr0e8tYqC5Okuima4hWHKcfaC1pMG2IJi9qpm PjQsBDIhEwknUI5kNqqrIDdsaJsv91k+n6GLjM5HD/5jWKNkeuiQ+BpL4V5KVzzN/PLGdacYLaPNt YMGyhqyxRhj0gULkW1cXPeKA4mecYCg2d9qiSRig/p8CVyNni+SAgFxdAD+xtH8qbRF7of3qn9jhX mdJLkb+UthvV+VKUT/Bbj8CNVOTtgS2PwxQc9NLjYL+VxUASHKHR+c/j+MwqqUGPyJcWPVXOMT0s/ OOtLx7+sAiV6YvxteqTg==; Original-Received: from [87.69.77.57] (port=2245 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfdsR-0007Yc-CG; Sat, 16 Apr 2022 04:33:55 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288473 Archived-At: > diff --git a/doc/lispref/windows.texi b/doc/lispref/windows.texi > index 43f222d..abc8ada 100644 > --- a/doc/lispref/windows.texi > +++ b/doc/lispref/windows.texi > @@ -2596,13 +2596,11 @@ Choosing Window > > @defopt display-buffer-alist > The value of this option is an alist mapping conditions to display > -actions. Each condition may be either a regular expression matching a > -buffer name or a function that takes two arguments: a buffer name and > -the @var{action} argument passed to @code{display-buffer}. If either > -the name of the buffer passed to @code{display-buffer} matches a > -regular expression in this alist, or the function specified by a > -condition returns non-@code{nil}, then @code{display-buffer} uses the > -corresponding display action to display the buffer. > +actions. Each condition is passed to @code{buffer-match-p}, along > +with the buffer name and the @var{action} argument passed to > +@code{display-buffer}. If it returns a non-nil value, then > +@code{display-buffer} uses the corresponding display action to display > +the buffer. Since buffer-match-p is not documented in the manual, I think this change is for the worse, as it leaves CONDITIONS undocumented. Or am I missing something? In any case, referencing a function without an explicit cross-reference is not a good style for the manual, unless the function is described in the same node and prior to the reference. Thanks.