From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase Date: Mon, 06 Jun 2022 15:43:19 +0300 Message-ID: <83ee027yjc.fsf@gnu.org> References: <37af046b-4257-6370-c765-9290eae73fd4@gmail.com> <831qw6dzra.fsf@gnu.org> <0278e759-237b-a32b-4b1f-fbdacf39c8ef@gmail.com> <83pmjpar0x.fsf@gnu.org> <9e8a8b42-2f42-3027-2ec0-97744bb91911@gmail.com> <83sfoja2xp.fsf@gnu.org> <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> <83sfoj7x6f.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15484"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, 55696@debbugs.gnu.org, jeff.kowalski@gmail.com To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 06 15:02:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyCN8-0003tt-NJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Jun 2022 15:02:18 +0200 Original-Received: from localhost ([::1]:58116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyCN7-0002nx-63 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Jun 2022 09:02:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyC5U-0007Uq-Gz for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2022 08:44:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40712) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyC5S-0004Pk-1z for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2022 08:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyC5R-0007Ul-Sw for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2022 08:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jun 2022 12:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55696 X-GNU-PR-Package: emacs Original-Received: via spool by 55696-submit@debbugs.gnu.org id=B55696.165451942228759 (code B ref 55696); Mon, 06 Jun 2022 12:44:01 +0000 Original-Received: (at 55696) by debbugs.gnu.org; 6 Jun 2022 12:43:42 +0000 Original-Received: from localhost ([127.0.0.1]:34609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyC57-0007Tn-Vb for submit@debbugs.gnu.org; Mon, 06 Jun 2022 08:43:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyC54-0007TM-UY for 55696@debbugs.gnu.org; Mon, 06 Jun 2022 08:43:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyC4x-0004Lt-A1; Mon, 06 Jun 2022 08:43:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Z/P+WmgUzAmHDrguVzbsQH+H+0Dqm3zcJb2kqGvHqPc=; b=U1D0V3MdUJ6U NwWsXWCBcLuZ4btxMu5AVSCvRJIn1Ccu2hmUB3nLag7/47VU572cQMWezfIDiH6Hmnc9oD/TjLFkB bZVEFjlxaeN/9zF+6SMadZpy+xMSrxzc/KoJGfgclv1dABPhfFsdW5ztANewu8YQR24YpMzBxp20d 5uzd6OKu8QOOUOwWTXTOLE83SggJR5zyVOXLYIAfQnT9PQudV51g4/DJJV4/BlY9jyOsBRiuBSpfB BYGpknVeG3aZAQjG6tmnJu3w1gT98sEa725P1VpKgozTEIIaeXnYN1xUxS9SB3vXGzMmnccX9Xwco ocx5IYftXN1msv5TDXyepg==; Original-Received: from [87.69.77.57] (port=4375 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyC4w-0004Ss-MY; Mon, 06 Jun 2022 08:43:31 -0400 In-Reply-To: (message from Jim Porter on Sun, 5 Jun 2022 12:59:22 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233774 Archived-At: > Cc: rudalics@gmx.at, 55696@debbugs.gnu.org, jeff.kowalski@gmail.com > From: Jim Porter > Date: Sun, 5 Jun 2022 12:59:22 -0700 > > >> + if (Vface_remapping_alist) > > > > This should be > > > > if (!NILP (Vface_remapping_alist)) > > Thanks, fixed. A couple more nits: > +static enum body_unit > +window_body_unit_from_symbol (Lisp_Object unit) > +{ > + return > + (unit == intern ("remap") ? BODY_IN_REMAPPED_CHARS > + : NILP (unit) ? BODY_IN_CANONICAL_CHARS > + : BODY_IN_PIXELS); > +} We already have the Qremap symbol in our sources, so you could use that instead of calling 'intern' at run time. > +The optional argument PIXELWISE defines the units to use for the > +width. If nil, return the largest integer smaller than WINDOW's pixel > +width in units of the character width of WINDOW's frame. If PIXELWISE > +is `remap' and the default face is remapped (see > +`face-remapping-alist'), use the remapped face to determine the > +character width. For any other value, return the width in pixels. ^^^^^^^^^^^^^^^^^^^ "For any other non-nil value...", like in the manual. > +The optional argument PIXELWISE defines the units to use for the > +height. If nil, return the largest integer smaller than WINDOW's > +pixel height in units of the character height of WINDOW's frame. If > +PIXELWISE is `remap' and the default face is remapped (see > +`face-remapping-alist'), use the remapped face to determine the > +character height. For any other value, return the height in > +pixels. */) Same here. I have no further comments; let's wait for Martin to chime in. Thanks.