all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: pedz@easesoftware.com, 57536-done@debbugs.gnu.org
Subject: bug#57536: 28.1; filenotify problems on macOS with symbolic links to directories
Date: Sat, 17 Sep 2022 18:37:29 +0300	[thread overview]
Message-ID: <83edwa107a.fsf@gnu.org> (raw)
In-Reply-To: <87k062oww7.fsf@gmx.de> (message from Michael Albinus on Sat, 17 Sep 2022 17:15:04 +0200)

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: pedz@easesoftware.com,  57536@debbugs.gnu.org
> Date: Sat, 17 Sep 2022 17:15:04 +0200
> 
> > I'd start by documenting that we no longer follow symlinks when
> > watching: that's a kind-of incompatible change.  Then I'd go by
> > complaints, if any.
> 
> I've extended already the doc yesterday, see (info "(elisp) File Notifications")
> 
> --8<---------------cut here---------------start------------->8---
>      If FILE is a symlink, it doesn’t follow that link.  Just FILE
>      itself will be watched.
> --8<---------------cut here---------------end--------------->8---
> 
> And it isn't a visible incompatibility. Yes, inotify and w32notify did
> follow the link, and they have raised events for the link target. But in
> file-notify-handle-event this event must be adapted in order to keep the
> unified action names we have introduced in filenotify.el. And the event
> will be propagated only in case the full file name in that event is
> supervised via file-notify-add-watch. This didn't happen for the
> followed file names (the symlink targets), such events weren't
> propagated, and the effect for the users was the same as when inotify
> and w32notify didn't follow the link (as we have now). So I believe we
> have nothing to explain but just the clarification I have done
> yesterday.

Yes, you are right.

> >From my pov, this bug can be closed. The problem with kqueue I will work
> on once I have a new FreeBSD VM.

Fine by me, closing.

Thanks.





      reply	other threads:[~2022-09-17 15:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 23:34 bug#57536: 28.1; filenotify problems on macOS with symbolic links to directories Perry Smith
2022-09-02  6:25 ` Eli Zaretskii
2022-09-04 11:42   ` Michael Albinus
2022-09-04 13:10     ` Eli Zaretskii
2022-09-04 14:26       ` Michael Albinus
2022-09-04 14:49         ` Eli Zaretskii
2022-09-07 12:20           ` Eli Zaretskii
2022-09-07 15:57             ` Michael Albinus
2022-09-16 15:27           ` Michael Albinus
2022-09-16 15:56             ` Eli Zaretskii
2022-09-16 16:39               ` Michael Albinus
2022-09-17  9:02                 ` Michael Albinus
2022-09-17  9:43                   ` Eli Zaretskii
2022-09-17 13:16                     ` Michael Albinus
2022-09-17 14:07                       ` Eli Zaretskii
2022-09-17 15:03                         ` Michael Albinus
2022-09-17 13:27           ` Michael Albinus
2022-09-17 13:53             ` Eli Zaretskii
2022-09-17 15:15               ` Michael Albinus
2022-09-17 15:37                 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83edwa107a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57536-done@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=pedz@easesoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.