From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58042: 29.0.50; ASAN use-after-free in re_match_2_internal Date: Thu, 06 Oct 2022 09:59:21 +0300 Message-ID: <83edvlqvxy.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33601"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58042@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 06 09:10:07 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogL1C-0008dE-70 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Oct 2022 09:10:06 +0200 Original-Received: from localhost ([::1]:37530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogL1B-0001m0-93 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Oct 2022 03:10:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogKrU-0005Se-AP for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 03:00:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogKrT-0000e9-TQ for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 03:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogKrS-0004H7-JX for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 03:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Oct 2022 07:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58042 X-GNU-PR-Package: emacs Original-Received: via spool by 58042-submit@debbugs.gnu.org id=B58042.166503957016366 (code B ref 58042); Thu, 06 Oct 2022 07:00:02 +0000 Original-Received: (at 58042) by debbugs.gnu.org; 6 Oct 2022 06:59:30 +0000 Original-Received: from localhost ([127.0.0.1]:58676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogKqv-0004Ft-RO for submit@debbugs.gnu.org; Thu, 06 Oct 2022 02:59:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogKqu-0004Ff-4U for 58042@debbugs.gnu.org; Thu, 06 Oct 2022 02:59:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42582) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogKqo-0000Wt-Te; Thu, 06 Oct 2022 02:59:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IMWPnme+e5Yw+47KmIBaTqV7TDvugykmDG6Mw0rXUfo=; b=O4JHnPvERDnsnm/r44T3 Bokubgwv+B2i+ceGaUjFSKG5MNvpQsZtpWtGDT5y+aegTmIjB+qeAt4er/x4gVgu91IBfYWibDvtA stNuMzhZzub4vZkknhEhYKTHtCJxVzq1hmiFTzQkJ3Kbri69lvD0XE5ma78gvgMS8bee8tWh+d58U +p9eoltXar3jsqJTsmQConkM9XUzROY5C5tBYUg0O1CAaGtOdXyPnBeenBk6Y7psa8mjapPmra73M 2WPkJx1tUINz+laTeoCEeKyy6GijIIFzSEDC2K6ss1oQ9hMgugUMzTQYKr2p7j30BAAlrzJygjAOW pfNoLcNcgiOJ2A==; Original-Received: from [87.69.77.57] (port=4106 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogKqm-00067y-GB; Thu, 06 Oct 2022 02:59:21 -0400 In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Thu, 06 Oct 2022 07:35:26 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244601 Archived-At: > From: Gerd Möllmann > Date: Thu, 06 Oct 2022 07:35:26 +0200 > > Can we come to a decision about what to do with probably_quit, based > what we know now? The threads under this bug are a bit deep and > complicated, so I'd like to make this a bit more visible. > > I think the problem has been analyized to be: > > 1. The re_matcher uses char* pointer P into data of string S. > 2. The re_matcher uses maybe_quit > 3. maybe_quit can call garbage_collect > 4. garbage_collect can call Lisp (finalizers, redisplay) > (4a. That Lisp can again garbage_collect) > 5. One of the GCs can relocate the string data of S in step 1. > 6. P is then invalid. > > Possible solution: > > Inhibit GC in probably_quit, so that P remains valid. > > Q: Should we do that? IMO, yes. > And if so, when? "Now"?