From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55900: [PATCH] Hierarchy =?UTF-8?Q?=E2=80=93?= Defer the Computation of Children Date: Thu, 27 Oct 2022 20:17:26 +0300 Message-ID: <83edutkwyh.fsf@gnu.org> References: <83wndny5i7.fsf@gnu.org> <87mtei1cii.fsf@outlook.com> <1383718586.2581914.1655024858024@mail.yahoo.com> <838rodaabv.fsf@gnu.org> <83iln84jw0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5468"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55900@debbugs.gnu.org To: Jaft Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 19:19:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo6XX-0001D6-Qe for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 19:19:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo6W5-0004n8-4s; Thu, 27 Oct 2022 13:18:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6W2-0004T0-RF for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 13:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo6W2-0007A2-I5 for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 13:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo6W1-0003BY-UR for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 13:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 17:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55900 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55900-submit@debbugs.gnu.org id=B55900.166689106112218 (code B ref 55900); Thu, 27 Oct 2022 17:18:01 +0000 Original-Received: (at 55900) by debbugs.gnu.org; 27 Oct 2022 17:17:41 +0000 Original-Received: from localhost ([127.0.0.1]:59185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6Vh-0003B0-HK for submit@debbugs.gnu.org; Thu, 27 Oct 2022 13:17:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6Vf-0003An-RS for 55900@debbugs.gnu.org; Thu, 27 Oct 2022 13:17:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6Va-00077E-1H; Thu, 27 Oct 2022 13:17:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lQUdQlux96BmFbLaHLVmkbEk7JL36UHugu/wMIMxLzM=; b=mJpJe6G1/xGHk3l9v4F7 vN0mTy2vuTpLUupxt0YyydE6aPym4dTckBTj5Ja1ofcFcce8MXsCDwM8fJh9DaKa6sWqChbTKYQNF mjtkdqs8/VKsGioMidDSsxqTApo4GgwNpCO374RO0hPjVv1m5g4chO4qsuD6mphStnrhH2Vku/+oP kbL+IZM5K/927SfNxVS41KlCU9HAELt+AhlkOE9fvZNt8pIVt7mylLsqPLRVPA0AIrKUa5iyyP41Q vIwB+mTgzGQgFMEHzlO6YsOkaEGiZ67QnKx3qs6gvJ0JaXvz1yTqu73l2Yu2TtCxhhvM2dRYzc+cX mJ9Zq4WLhZyxYw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6VY-0000sM-RD; Thu, 27 Oct 2022 13:17:33 -0400 In-Reply-To: (message from Jaft on Thu, 27 Oct 2022 16:13:05 +0000 (UTC)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246338 Archived-At: > Date: Thu, 27 Oct 2022 16:13:05 +0000 (UTC) > From: Jaft > Cc: "55900@debbugs.gnu.org" <55900@debbugs.gnu.org> > > I've submitted my copyright assignment and've been informed it's been completed. > > We should be ready to proceed, as far as I understand. Thanks. I installed the changeset, but one of the tests you added fails here: Test hierarchy-delayed-add-trees backtrace: signal(ert-test-failed (((should (equal (hierarchy-children hierarch ert-fail(((should (equal (hierarchy-children hierarchy '191) '(190 1 (if (unwind-protect (setq value-714 (apply fn-712 args-713)) (setq f (let (form-description-716) (if (unwind-protect (setq value-714 (app (let ((value-714 'ert-form-evaluation-aborted-715)) (let (form-descr (let* ((fn-712 #'equal) (args-713 (condition-case err (let ((signal- (let ((parentfn #'(lambda (item) (cond ((eql item ...) '191) ((eql i (closure (t) nil (let ((parentfn #'(lambda (item) (cond (... ...) (. ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name hierarchy-delayed-add-trees :document ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/emacs-lisp/hierarchy command-line() normal-top-level() Test hierarchy-delayed-add-trees condition: (ert-test-failed ((should (equal (hierarchy-children hierarchy ...) '(190 190.5))) :form (equal (190.5) (190 190.5)) :value nil :explanation (proper-lists-of-different-length 1 2 (190.5) (190 190.5) first-mismatch-at 0))) FAILED 24/68 hierarchy-delayed-add-trees (0.000000 sec) at lisp/emacs-lisp/hierarchy-tests.el:685 Could you please work on fixing this test? Thanks.