From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Sat, 29 Oct 2022 19:56:35 +0300 Message-ID: <83eduqh8l8.fsf@gnu.org> References: <11379.1667061172@alto> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16897"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 29 18:57:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oop90-0004CB-R4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Oct 2022 18:57:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oop8r-0007eQ-GI; Sat, 29 Oct 2022 12:57:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oop8o-0007eF-Tc for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 12:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oop8o-0007p5-MH for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 12:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oop8o-000088-Gk for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 12:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Oct 2022 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.1667062610482 (code B ref 58721); Sat, 29 Oct 2022 16:57:02 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 29 Oct 2022 16:56:50 +0000 Original-Received: from localhost ([127.0.0.1]:36490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oop8c-00007g-FT for submit@debbugs.gnu.org; Sat, 29 Oct 2022 12:56:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oop8a-00007R-5n for 58721@debbugs.gnu.org; Sat, 29 Oct 2022 12:56:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oop8U-0007mt-K8; Sat, 29 Oct 2022 12:56:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4D4kYQj+v1YCdnaXxqD+IaXJhlRQerUld87mBKQll8E=; b=gq1+D5j6WtQU cbjaWdNfVmZX5FnnE6DteIpZNcyKxqOCjNJTUO/4hKkYXnUqdZit1G6bNXxZkpCMxU85EZ6JPvTPR 4bqMeg+iRhwUcbUOKBQnURhvYg/W8yjfNfzNzE3qJlndbHCOM8lmDZ9jMV3441qn4LkYSiEQPa6ZN lgAgBVw+lTw2S0w9cYjuCiap9QBOlIC0jTOKLIna50N14Fd+eukvgIRsFq7gRqMkrlDhy+R6AReJl wGnZkr9zxlTs6v9lAR5gPebqNxAeDrTnURd/K+rQKHjziVrzuTCONXVK7mlSFgDhhAsle09CWEGU+ XOPsg6NuY9wHcOCCrWxHSw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oop8U-0001qf-2I; Sat, 29 Oct 2022 12:56:42 -0400 In-Reply-To: <11379.1667061172@alto> (message from Mike Kupfer on Sat, 29 Oct 2022 09:32:52 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246558 Archived-At: > From: Mike Kupfer > cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com > Date: Sat, 29 Oct 2022 09:32:52 -0700 > > So... (rename-file "a" "/tmp/newa" t) gives the original error. > > (rename-file "a" "/tmp/newa/" t) gives us /tmp/newa/a/b. > > What we want is /tmp/newa/b. > > I can think of 2 ways forward. One is to add an optional argument to > rename-file to get the desired behavior, like the copy-contents argument > to copy-directory. > > The other is for move-file-to-trash to call rename-file on the top-level > contents of the directory that is being trashed ("a/b" in my simple test > case), rather than on the directory itself. > > I think the first approach is preferable, in that it parallels the > definition of copy-directory. But either should work. Yet another possibility is to refrain from calling rename-file when the moved file is a directory, and instead to do what rename-file does, with a twist, "by hand". That is what I actually prefer, as nothing is really wrong with rename-file.