From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Wrong pointer comparison in w32fns.c
Date: Sun, 30 Oct 2022 14:47:07 +0200
Message-ID: <83edupfph0.fsf@gnu.org>
References: <CAAeL0STrMMp-g4HhuRy020QJf5T6uAZOnMMHfMfMsG9YfxQ8aA@mail.gmail.com>
 <838rkxhlqq.fsf@gnu.org>
 <CAAeL0STxSdmqHt_UmiZiDE1-+zFDNhgJjNveYaPzfyte_xXuZQ@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="1123"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Juanma Barranquero <lekktu@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 30 13:48:13 2022
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1op7jY-000Aa0-CH
	for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Oct 2022 13:48:12 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1op7ir-00084h-Ol; Sun, 30 Oct 2022 08:47:29 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1op7ip-000846-QR
 for emacs-devel@gnu.org; Sun, 30 Oct 2022 08:47:27 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1op7ip-00059f-FT; Sun, 30 Oct 2022 08:47:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=416zUKX0BZnLrLkZhNtNYdgtMAewlHHrejyJvtd7Abs=; b=HHwnyaxe9RXf
 oJ/Kj8iLin0ACUffKOMyzHk4MUPTMQEOvtUdP5JIlwQmBt9Zs1Qv86H78Z/YkGMfSGfzzd0/mgWHI
 k1op8UXWslv5FzqgGNXD/0S8hWRrYeP+sJML8EmxOt73f2xsvtI7o7aveomoNmICAWaSC246e99TA
 Zjh4Pr6mhet/I7N0LS2DddwTQOmRqhQizpJAa2iK0AjDmvk89Yanp5rj9Ka/LrLqFHbsRLFk2W09a
 8IJe+9l9KgfnCMFDxstRXNOvHFd98da/PepbVnImq1uX2IiTFT4CJ2A8yaeKxiY934pZj86+xtmQP
 MIlIIjkY14o/ocymLFjBsg==;
Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1op7io-0003iG-2D; Sun, 30 Oct 2022 08:47:26 -0400
In-Reply-To: <CAAeL0STxSdmqHt_UmiZiDE1-+zFDNhgJjNveYaPzfyte_xXuZQ@mail.gmail.com>
 (message from Juanma Barranquero on Sun, 30 Oct 2022 13:13:06 +0100)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: "Emacs-devel" <emacs-devel-bounces@gnu.org>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:298809
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/298809>

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sun, 30 Oct 2022 13:13:06 +0100
> Cc: emacs-devel@gnu.org
> 
> Ah, possibly.
> 
> The output of StringFromGUD2 is then not checked, though perhaps it's assumed it will always fit in 64
> wchar_t..

It should be, since the GUID is a 128-bit number.

Anyway, I've made a change that should take care of both of these
issues.

Thanks.