From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability Date: Fri, 25 Nov 2022 14:19:30 +0200 Message-ID: <83edtrusz1.fsf@gnu.org> References: <837czkw7sl.fsf@gnu.org> <8335a8w643.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3552"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59544@debbugs.gnu.org, lx@shellcodes.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 13:20:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyXgb-0000iD-Pp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 13:20:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyXgZ-00015c-87; Fri, 25 Nov 2022 07:20:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyXgY-00015I-7i for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 07:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyXgX-0004PT-Om for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 07:20:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyXgX-0001U0-Kj for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 07:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 12:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 59544-submit@debbugs.gnu.org id=B59544.16693787555629 (code B ref 59544); Fri, 25 Nov 2022 12:20:01 +0000 Original-Received: (at 59544) by debbugs.gnu.org; 25 Nov 2022 12:19:15 +0000 Original-Received: from localhost ([127.0.0.1]:33797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyXfn-0001Sj-2K for submit@debbugs.gnu.org; Fri, 25 Nov 2022 07:19:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyXfm-0001SW-0U for 59544@debbugs.gnu.org; Fri, 25 Nov 2022 07:19:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyXfg-0003Sc-A3; Fri, 25 Nov 2022 07:19:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0XY/Jz18l/ZxRc6yP60qXtm+e0q5eFT6w7tnA9WRmy8=; b=FRrU2TRukKB3 4pC0cLNAmVX96DEtIuWSjVay6hmxOzbyCRevJhPwOYccJjqWV35XZAB5YzVkWIRrEETZtJUTJSX5K MlIrngNGr3LU6Tz+ToTWabfwBtBMP9NZnQ/kFUISa9ebfiOoxYu2ZRy5fopqvEsLW5vdbUEkFCBST FOeKQW6lP8jlbTuU5NkjELS/ulTn4O7JFUOZ5qETmAtEtQakoUZsO0KT7Kl+I3PwKzzq29CC/pPko AwROfvNzGxKzcuRgJU+xISuhzkwIsmRm7BQgTAIEJ33EZxlZDPHTnzWvjgVuDEV+U5vBdYrLc7vt8 sCJV2udPf2dsW9eSqdEPCw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyXff-00075S-Oi; Fri, 25 Nov 2022 07:19:08 -0500 In-Reply-To: (message from Stefan Kangas on Fri, 25 Nov 2022 00:56:32 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248994 Archived-At: > From: Stefan Kangas > Date: Fri, 25 Nov 2022 00:56:32 -0800 > Cc: Eli Zaretskii , 59544 <59544@debbugs.gnu.org> > > "lux" writes: > > >> Hmm, I'm not sure about the hard-coded 512 character line limit here. > >> ISTR that some people use much longer lines than that. > > > > Hi, do you have any suggestions? At present, I think hardcoding 512 is > > enough, thanks :-) > > No idea, really. 2^16? 2^20? > > But why not allocate it dynamically, getting rid of any such arbitrary > limits? AFAIU, grep (which we used before) doesn't have such limits, so > I fear that we otherwise risk introducing regressions. Yes, reallocating dynamically as needed would be best.