From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60669: Linux Emacs 27.1 custom toolbar icons Date: Mon, 09 Jan 2023 05:32:58 +0200 Message-ID: <83eds4pel1.fsf@gnu.org> References: <998e8e01-2c89-da4b-9c36-83b987af3bdf@ixont.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16377"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60669@debbugs.gnu.org To: David McCracken Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 09 04:33:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEiuW-00041h-AZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Jan 2023 04:33:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEiuG-0004XC-7D; Sun, 08 Jan 2023 22:33:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEiuE-0004Wq-PU for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 22:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEiuE-00034q-He for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 22:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEiuE-0000zZ-BT for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 22:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Jan 2023 03:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60669 X-GNU-PR-Package: emacs Original-Received: via spool by 60669-submit@debbugs.gnu.org id=B60669.16732351633776 (code B ref 60669); Mon, 09 Jan 2023 03:33:02 +0000 Original-Received: (at 60669) by debbugs.gnu.org; 9 Jan 2023 03:32:43 +0000 Original-Received: from localhost ([127.0.0.1]:35365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEitu-0000yp-U9 for submit@debbugs.gnu.org; Sun, 08 Jan 2023 22:32:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEits-0000yY-Gv for 60669@debbugs.gnu.org; Sun, 08 Jan 2023 22:32:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEitn-00031C-5z; Sun, 08 Jan 2023 22:32:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cnLfaMY2/URPZ73tGxNEOoF8kxWEvoQ4IaxuGzvEanE=; b=QeNAxdDbCvw2 6H3w6GMlJJROM/mAfRH1HVMZOjGLoX8XbiJC69JoUc0d9ubsCJmIbFPHa0zZRac5Xwz6ke2jeXflj rj6Pf71DN+8miu292eAF6bJM3yNkn+HkP4t6HFC1mqkhBu7yx+JbNaoIG9W2kZcAXz9abJQJPHnjn SRb4Um/xMGM/k+hUtyvnHVkZQwMTu3EVhCjEk9fOgxxIsDKvhggiyDskOji0GJeYgFLnr5CyGhppm q97zWWSMsF1ollmz3hk7VUwKAJ2kvzTOaer0XXTFYIGBOVffllEhyFrHbR1Syh+AMCndqQNoGtNM9 KSyc6+xtIuLdg0E8YAWXww==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEitm-0003SK-IW; Sun, 08 Jan 2023 22:32:34 -0500 In-Reply-To: <998e8e01-2c89-da4b-9c36-83b987af3bdf@ixont.com> (message from David McCracken on Sun, 8 Jan 2023 13:01:26 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252978 Archived-At: > Date: Sun, 8 Jan 2023 13:01:26 -0800 > From: David McCracken > > The Emacs 27.1 provided (apt-get install) by Ubuntu 22.04 reduces > support for custom toolbar icons. It only works with B/W pbm files and > only if located in /usr/share/emacs/27.1/etc/images and only if there > isn't an xpm file with the same base name. i.e. name.pbm works but not > if there is a name.xpm in the directory. If these conditions are not met > nothing is displayed. > > This does not seem to be baked into Emacs 27.1 because these > restrictions don't exist in Windows Emacs 27.1. They are also not > inherent in Linux because they don't exist in Linux Emacs 26.1. > > There are two serious problems with these seemingly unnecessary changes. > B/W icons reduce not just the aesthetic quality but also subtle visual > clues that help an icon convey its meaning. Accepting only icons in the > version-numbered installation directory means that custom icons are > wiped out by upgrading Emacs. > > The installer program I provide with my Emacs library stores its (xpm) > icons in ~/icons (a directory created by my installer). My library > accesses these by e.g. > (tool-bar-add-item "~/icons/lxa-pin" > Linux Emacs 27.1 is the only version in which this does not work. To > test whether it does not like that the directory is relatively insecure, > I tried moving my icons to /usr/local but they were still ignored. In > all other versions, adding the xpm extension to the reference causes it > to fail but I tested this anyway and it accomplished nothing. Can you please show a reproducible recipe, starting from "emacs -Q", that exhibits the problem you are describing? I don't think I understand what exactly doesn't work in your case. Also, please use "M-x report-emacs-bug" to post the details, as that command collects important details about the Emacs build configuration that make investigation easier. Thanks.