From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Sat, 10 Jun 2023 20:56:26 +0300 Message-ID: <83edmjyzed.fsf@gnu.org> References: <834jnl4ub9.fsf@gnu.org> <831qio4z3d.fsf@gnu.org> <83bkhq2s19.fsf@gnu.org> <83v8fvznmn.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15070"; mail-complaints-to="usenet@ciao.gmane.io" Cc: spacibba@aol.com, 63913-done@debbugs.gnu.org, monnier@iro.umontreal.ca To: Morgan Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 10 19:57:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q82qJ-0003jn-LR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jun 2023 19:57:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q82q2-0006QA-Fe; Sat, 10 Jun 2023 13:57:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q82pi-0006PL-Jb for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 13:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q82pi-0005gm-BT for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 13:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q82pi-0003GP-2g for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 13:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63913-done@debbugs.gnu.org id=D63913.168641978212484 (code D ref 63913); Sat, 10 Jun 2023 17:57:02 +0000 Original-Received: (at 63913-done) by debbugs.gnu.org; 10 Jun 2023 17:56:22 +0000 Original-Received: from localhost ([127.0.0.1]:36229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q82p4-0003FI-Ci for submit@debbugs.gnu.org; Sat, 10 Jun 2023 13:56:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q82p2-0003F3-QJ for 63913-done@debbugs.gnu.org; Sat, 10 Jun 2023 13:56:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q82ox-0005cA-3E; Sat, 10 Jun 2023 13:56:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hCEkpURuQTjYFm1X9amcMo0cNDdNcVda28sSHMihjn8=; b=UF3xxNVHobNI dAabgVjhBSs7JZCQItpGC937WV7Ofsm1eu7VCoxek8G09+5SSpe+0IMbtjKqrKO0Lf0h5P0AF4YAi 6vKeqDLtzd9sFfBFYhhXei9+DU6EWOwlc20LmrpWjwesG099UJwWsLkYtmmSNTjsy5+/pTisbDnAv WFpcCrhBEUUkjx93otNVD0FMf/Bybxb7Yh2YoMDkIudbcjhknsIH0Q1Et5wXZQjo4OR2ldgxXZUe6 hgweLsTjvjdvBuuK//eYKb9Rlk0XcIwORrHrqPuG1sTeFDYd3jOvQHnHsJIv7eXwE2PfzjLE2HrOO EG3vF5t1gxMuVx56t5GLNQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q82ow-0005BE-IK; Sat, 10 Jun 2023 13:56:14 -0400 In-Reply-To: (message from Morgan Smith on Sat, 10 Jun 2023 13:34:32 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263233 Archived-At: > From: Morgan Smith > Cc: Stefan Monnier , spacibba@aol.com, > 63913-done@debbugs.gnu.org > Date: Sat, 10 Jun 2023 13:34:32 -0400 > > Eli Zaretskii writes: > > > > > Thanks, installed on the emacs-29 branch, and closing the bug. > > Would you also consider installing the test patch I sent previously? > I've reattached it here for your convenience. Installed. But please in the future try to follow better our conventions for log messages, to avoid the need for me to manually fix the log message when installing: . always mention the bug number in the log message . quote symbols 'like this' . make sure the lines are not too long (they will be longer by 8 columns when converted to a ChangeLog as part of tarring the release)