From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65006: 29.1.50; c-ts-mode: else block not indented right on TAB Date: Wed, 02 Aug 2023 20:05:22 +0300 Message-ID: <83edklz86l.fsf@gnu.org> References: <59aa8ff84460f695fbf94db4849f1596@sadiqpk.org> <83zg39znkq.fsf@gnu.org> <3B97B92B-BCBA-49B0-91EE-FD3F0CED268E@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31362"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sadiq@sadiqpk.org, 65006@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 02 19:06:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRFIe-0007u1-2B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Aug 2023 19:06:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRFIU-0005vg-Sq; Wed, 02 Aug 2023 13:06:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRFIR-0005uv-3L for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 13:06:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRFIQ-0004Ke-Oc for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 13:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRFIQ-0005eE-AD for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 13:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Aug 2023 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65006 X-GNU-PR-Package: emacs Original-Received: via spool by 65006-submit@debbugs.gnu.org id=B65006.169099592321663 (code B ref 65006); Wed, 02 Aug 2023 17:06:02 +0000 Original-Received: (at 65006) by debbugs.gnu.org; 2 Aug 2023 17:05:23 +0000 Original-Received: from localhost ([127.0.0.1]:50090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRFHm-0005dL-ME for submit@debbugs.gnu.org; Wed, 02 Aug 2023 13:05:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRFHk-0005d6-GI for 65006@debbugs.gnu.org; Wed, 02 Aug 2023 13:05:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRFHe-00049U-Pj; Wed, 02 Aug 2023 13:05:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AKD9k7GXITi4aA4vWvDyUKwyN7la8UITICXKChwhgrM=; b=ZA9kcIErY0lI c5YzW8w23LZUm26Zcjkha85fB3CHE8rEZqUdJfE1h3ri/lsS+hn/lCb4MpoasoDHaebi/koYDAbpQ 1+JZOQ0tAC9UrjWX/jaPYnUNA7T1amXq3fnrGfNdHjuM36rCe6zArwkzOfwN0Z9qsH8UyXSSWJeHq SIJLpwWlnBYy6YCaR7n+kI6AvLnQzbWqAoW5rYODKXkYtlWuzH6E+DF1tvW8QpPyw7hHI4pf1ptPK FcZ9nnEgiZj+nXUPSr1hcUeqQZris8dVr13CoP8JlnwNNGukvjOSuocGVvmXk3kZN3pGgfM2qSv/F d0hieqiB7X7CS8i2DamGOg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRFHe-0006Ir-9G; Wed, 02 Aug 2023 13:05:14 -0400 In-Reply-To: <3B97B92B-BCBA-49B0-91EE-FD3F0CED268E@gmail.com> (message from Yuan Fu on Wed, 2 Aug 2023 09:46:54 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266528 Archived-At: > From: Yuan Fu > Date: Wed, 2 Aug 2023 09:46:54 -0700 > Cc: Mohammed Sadiq , > 65006@debbugs.gnu.org > > >> afair, this did seem to work in the past. May be this > >> happened after I updated treesitter-c module, idk. > > Yeah, (sign) I can reproduce this with the latest tree-sitter-c grammar but not the old one. Someone decides to add an else_clause node into the grammar [1] two weeks ago. How was the else clause parsed in the previous versions of the grammar? Will the proposed fix work with the older versions of the grammar? > > Yuan, can you look into this, please? > > Should the fix go into emacs-29 or master? To emacs-29, please. > We really need some way to mandate a version of grammar. These breaking changes are far more frequent than I originally thought. Who will track all those versions and record which ones are supported? And many grammar libraries don't have versions at all, so we will have to track commits instead.