From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64791: 30.0.50; [PATCH] Fix dired mismatch on some filenames Date: Mon, 04 Sep 2023 15:17:07 +0300 Message-ID: <83edje5e0s.fsf@gnu.org> References: <87sf9gozbl.fsf@ledu-giraud.fr> <83fs5g8392.fsf@gnu.org> <87lef8ovgc.fsf@ledu-giraud.fr> <835y6c7yvo.fsf@gnu.org> <87ttsbbbfy.fsf@ledu-giraud.fr> <83zg235d47.fsf@gnu.org> <83wmx75aad.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11030"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64791@debbugs.gnu.org, manuel@ledu-giraud.fr To: stefankangas@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 04 14:18:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qd8Wz-0002cc-Az for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Sep 2023 14:18:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qd8Wt-0005iJ-4e; Mon, 04 Sep 2023 08:18:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd8Wp-0005ep-Hn for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 08:18:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qd8Wp-0006n5-7p for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 08:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qd8Wo-0002jz-GS for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 08:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64791 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64791-submit@debbugs.gnu.org id=B64791.169382985410498 (code B ref 64791); Mon, 04 Sep 2023 12:18:02 +0000 Original-Received: (at 64791) by debbugs.gnu.org; 4 Sep 2023 12:17:34 +0000 Original-Received: from localhost ([127.0.0.1]:48987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd8WM-0002jF-5T for submit@debbugs.gnu.org; Mon, 04 Sep 2023 08:17:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd8WK-0002j0-Ih for 64791@debbugs.gnu.org; Mon, 04 Sep 2023 08:17:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd8WD-0006Z3-ER; Mon, 04 Sep 2023 08:17:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1Cm1u+SefvnxtQ7HLxBa/YEE9A/phU4QSW6a1kS1iXo=; b=btFz2ytoJxBF ii779mZcINGzLMYtMeaj2CiHKfgb5UypuEECmrfzMmX84KP55nfw/DnIzgnAXWwYFS5+KoiOYXPzU gU+N2jfz0JXs3cvOfEeIkI8GzrujLyyRbDTheZrwXHJ9v/iXRhiy4/3jT5mcmhBaavM/MTR9Lx225 +/9ayUvh34wgRlck8RFccm8UunGH/gjnSvUPtPe7lMxHiRjK0OpOKFUdUMzxpcyAk3baZNNhLv8cm FwV2KithQdF1HugaYWWCs6KwmTV8BOrIjVkaW1sdYA+kn00HTUqKv7Gd7q3O5OCrfpQGCjpYRL4uM rXQdqAplNn7yyD3M0gAQAA==; In-Reply-To: <83wmx75aad.fsf@gnu.org> (message from Eli Zaretskii on Sun, 03 Sep 2023 22:25:30 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269234 Archived-At: > Cc: 64791@debbugs.gnu.org, manuel@ledu-giraud.fr > Date: Sun, 03 Sep 2023 22:25:30 +0300 > From: Eli Zaretskii > > > -(defvar insert-directory-program (purecopy "ls") > > +(defvar insert-directory-program > > + (if (and (memq system-type '(berkeley-unix darwin)) > > + (executable-find "gls")) > > + (purecopy "gls") > > + (purecopy "ls")) > > "Absolute or relative name of the `ls'-like program. > > This is used by `insert-directory' and `dired-insert-directory' > > \(thus, also by `dired').") > > If we believe "gls" is the only popular name, I guess that's good > enough. Actually, I take this back: this defvar will be computed when files.el is loaded, which is at dump time. So this is not TRT, since the conditions and the environment at dump time could be very different from those at run time. It could be even on another machine. So I once again suggest to make this a defcustom. This has two advantages: . it will be evaluated at Emacs startup, not at dump time . it will allow users to customize the value and thus avoid costly search for the program and prevent finding the wrong version of 'ls'