From: Eli Zaretskii <eliz@gnu.org>
To: Steven Allen <steven@stebalien.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 68294@debbugs.gnu.org
Subject: bug#68294: [PATCH] Set the 'name' prop in 'define-advice'
Date: Sun, 07 Jan 2024 08:27:03 +0200 [thread overview]
Message-ID: <83edetsloo.fsf@gnu.org> (raw)
In-Reply-To: <87h6jqwdnn.fsf@stebalien.com> (message from Steven Allen on Sat, 06 Jan 2024 09:54:36 -0800)
> From: Steven Allen <steven@stebalien.com>
> Date: Sat, 06 Jan 2024 09:54:36 -0800
>
> In addition to naming the advice function 'symbol@name', set the 'name'
> property to NAME. The code should be good, but I'm less sure about the
> updated documentation.
>
> Requested in Bug#68114.
Stefan, any comments?
> @defmac define-advice symbol (where lambda-list &optional name depth) &rest body
> This macro defines a piece of advice and adds it to the function named
> -@var{symbol}. The advice is an anonymous function if @var{name} is
> -@code{nil} or a function named @code{symbol@@name}. See
> -@code{advice-add} for explanation of other arguments.
> +@var{symbol}. If @var{name} is non-nil, the advice is named
> +@code{symbol@@name} and installed with the name @var{name}; otherwise,
^^^^^^^^^^^^^^^^^^^
This should be @code{@var{symbol}@@@var{name}}.
> +** 'define-advice' now sets the new advice's 'name' property to NAME
> +Named advice defined with 'define-advice' can now be remove with
^^^^^^
This should be "removed".
next prev parent reply other threads:[~2024-01-07 6:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 17:54 bug#68294: [PATCH] Set the 'name' prop in 'define-advice' Steven Allen
2024-01-07 6:27 ` Eli Zaretskii [this message]
2024-01-07 14:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 15:42 ` Steven Allen
2024-01-13 9:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83edetsloo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68294@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.