From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#16169: 24.3.50; isearch.el regression between 2013-12-05 and 2013-12-08 Date: Mon, 16 Dec 2013 09:51:51 -0800 (PST) Message-ID: <83e15b06-f550-4e34-94af-d7646abd45ea@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1387216402 27858 80.91.229.3 (16 Dec 2013 17:53:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Dec 2013 17:53:22 +0000 (UTC) To: 16169@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 16 18:53:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VscM9-00070x-N1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Dec 2013 18:53:25 +0100 Original-Received: from localhost ([::1]:57462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VscM9-000574-Cg for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Dec 2013 12:53:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VscLw-00054r-Ow for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:53:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VscLm-0001ds-NL for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:53:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VscLm-0001do-JF for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VscLm-0006bq-8k for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2013 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16169 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138721634825350 (code B ref -1); Mon, 16 Dec 2013 17:53:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Dec 2013 17:52:28 +0000 Original-Received: from localhost ([127.0.0.1]:54285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VscLD-0006an-Bv for submit@debbugs.gnu.org; Mon, 16 Dec 2013 12:52:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54027) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VscL9-0006aY-RT for submit@debbugs.gnu.org; Mon, 16 Dec 2013 12:52:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VscKz-0001Bz-OW for submit@debbugs.gnu.org; Mon, 16 Dec 2013 12:52:23 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VscKz-0001Bv-LB for submit@debbugs.gnu.org; Mon, 16 Dec 2013 12:52:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VscKr-0004eg-23 for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:52:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VscKi-00011Q-5c for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:52:04 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:20130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VscKi-0000zO-0D for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:51:56 -0500 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBGHpsll003824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Dec 2013 17:51:54 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGHpqSl000806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 16 Dec 2013 17:51:53 GMT Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGHppK1006692 for ; Mon, 16 Dec 2013 17:51:51 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82078 Archived-At: There are only 3 lines of code that were changed in isearch.el to introduce this regression. I don't understand the code well enough to suggest what's wrong, and I don't yet have a simple recipe from emacs -Q. But with my setup, when I do C-a from within Isearch it no longer exits Isearch. Maybe that description will ring a bell? Here is a diff between the two isearch.el versions (from 12-05 and 12-08): *************** *** 637,642 **** --- 637,644 ---- ;; isearch is invoked. (defvar isearch-input-method-local-p nil) =20 + (defvar isearch--saved-overriding-local-map nil) +=20 ;; Minor-mode-alist changes - kind of redundant with the ;; echo area, but if isearching in multiple windows, it can be useful. =20 *************** *** 904,909 **** --- 906,914 ---- =20 (setq overriding-terminal-local-map isearch-mode-map) (run-hooks 'isearch-mode-hook) + ;; Remember the initial map possibly modified + ;; by external packages in isearch-mode-hook. (Bug#16035) + (setq isearch--saved-overriding-local-map overriding-terminal-local-map= ) =20 ;; Pushing the initial state used to be before running isearch-mode-hoo= k, ;; but a hook might set `isearch-push-state-function' used in *************** *** 2235,2241 **** (cond ;; Don't exit Isearch if we're in the middle of some ;; set-temporary-overlay-map thingy like universal-argument--mode. ! ((not (eq overriding-terminal-local-map isearch-mode-map))) ;; Don't exit Isearch for isearch key bindings. ((commandp (lookup-key isearch-mode-map key nil))) ;; Optionally edit the search string instead of exiting. --- 2240,2246 ---- (cond ;; Don't exit Isearch if we're in the middle of some ;; set-temporary-overlay-map thingy like universal-argument--mode. ! ((not (eq overriding-terminal-local-map isearch--saved-overriding-lo= cal-map))) ;; Don't exit Isearch for isearch key bindings. ((commandp (lookup-key isearch-mode-map key nil))) ;; Optionally edit the search string instead of exiting. I'm guessing that it will take someone familiar with the isearch.el code (e.g. Juri) much less time to figure out what is wrong here than it will for me to try to understand the code and narrow things down in my setup to figure it out. And if you can offer suggestions wrt things to check I'll be glad to do so. There might be other differences as well, but so far I haven't noticed any. I haven't tried much, though, and there is a lot to try, since the code has been altered in fundamental ways since the end of September. The good news is that at least simple, superficial use of Isearch in my setup does not show other breakage. Hoping you can enlighten me a bit about this - what to check etc. Or that if there is an Emacs bug perhaps you can recognize it, given only the info provided here. Thx. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-12-08 on ODIEONE Bzr revision: 115426 jan.h.d@swipnet.se-20131208125914-y6dc16jem2hg3tao Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include'