From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#31760: 26.1; ruby-mode enables flymake-rubocop by default if the rubocop executable exists Date: Fri, 15 Jun 2018 18:16:00 +0300 Message-ID: <83d8f202-8842-56fe-0350-5f2fa9a01d67@yandex.ru> References: <87k1r972fp.wl-bordjukov@gmail.com> <87po11i0he.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1529078547 8912 195.159.176.226 (15 Jun 2018 16:02:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Jun 2018 16:02:27 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 Cc: 31760@debbugs.gnu.org, Bozhidar Batsov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Petko Bordjukov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 15 18:02:23 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTrB8-0002A3-B4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jun 2018 18:02:22 +0200 Original-Received: from localhost ([::1]:47810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTrDD-0002FA-Jt for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jun 2018 12:04:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTqTJ-0005LL-Ce for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 11:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTqTG-0001aO-7P for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 11:17:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42649) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTqTG-0001aH-1q for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 11:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fTqTF-0001N7-MT for bug-gnu-emacs@gnu.org; Fri, 15 Jun 2018 11:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jun 2018 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31760 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31760-submit@debbugs.gnu.org id=B31760.15290757705209 (code B ref 31760); Fri, 15 Jun 2018 15:17:01 +0000 Original-Received: (at 31760) by debbugs.gnu.org; 15 Jun 2018 15:16:10 +0000 Original-Received: from localhost ([127.0.0.1]:50546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTqSQ-0001Lw-Gz for submit@debbugs.gnu.org; Fri, 15 Jun 2018 11:16:10 -0400 Original-Received: from mail-wr0-f171.google.com ([209.85.128.171]:41648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTqSP-0001Ll-Tj for 31760@debbugs.gnu.org; Fri, 15 Jun 2018 11:16:10 -0400 Original-Received: by mail-wr0-f171.google.com with SMTP id h10-v6so10271370wrq.8 for <31760@debbugs.gnu.org>; Fri, 15 Jun 2018 08:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bYyHV3LvikBpJMr9YyOvYlLqyDev1HdJV5RmjriJ7jY=; b=WkgEiNFHqsKafoSMfKUjM9Ko1qkGoIsQKXDkmGlpOFdpHGyWFWoySkAJelK26SZQmz 8rFa2DCwMekL1H3LZ6o6b9+23TFP1HiwIso4Jp1phFCl4OH04WULBQ2ikFXD2hm5QDrx wts7pZTG7xgwEw3JPgY3YRgdmxt6CJg8B2FOKdtxDTD8ADOCXrvWKMkZlMh5azZLSBoP 54FLSlShl0p9gOKRjB62EziGUnVZ75TYHQ6qSFliCdailK9NNl6qI6YED074FEBxxNVQ 6eTh/qQJfDRggBOjhHhOX/Ezy4lwTCEufJ7BRqCf8qUoFCe4utO4xtBDJwtv+BnmciZ2 UJMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bYyHV3LvikBpJMr9YyOvYlLqyDev1HdJV5RmjriJ7jY=; b=kHB/hHNIzg6x1hrz9nQUyBFsz556XgaEmrD0rBGjrlk3DT6fDqEuC8/JmNvopZ0Vib /zFt1bctX2+J+vacL8KuTkfS2NmztHOrDeM3We+36Q2PTYsdCkmTMTENY3Jpt0qoTDS/ dNrdQ3wbf7OiRVj4+T3C+wPi/oVwzRD7qEX8bq6ILhjGVyEBPrXhFgPx1QHJgU+KHpLB 15sLPoLwnK2XUS2mLZMS7+0pBOVVy1xpQWeURqmAfqXRgYK4ag09xAiJgkIsCYlRtbDL sYsfnbv8UK2o93isRtY9I7ZVU+EVOdmumVljSBl7yef+N7Pj3AV5GvCkAQ22pS9Rxh0C R5QQ== X-Gm-Message-State: APt69E1NlfivkiRFUVv3PTPVmET37O+Icsr3/xNTu/c+iSeFDILfcqpO c79ow67/e6zN382RmgEw9CU= X-Google-Smtp-Source: ADUXVKIju1NjLKwfg16P3ZWiOB0R+u/XoLYNoBqljv4C4SU7j899Row0CJNc7HLDmuyNzmMjexZ0nw== X-Received: by 2002:adf:f090:: with SMTP id n16-v6mr2169307wro.49.1529075763986; Fri, 15 Jun 2018 08:16:03 -0700 (PDT) Original-Received: from [192.168.0.200] ([212.50.99.193]) by smtp.googlemail.com with ESMTPSA id f18-v6sm11474529wro.1.2018.06.15.08.16.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jun 2018 08:16:02 -0700 (PDT) In-Reply-To: <87po11i0he.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147459 Archived-At: On 6/8/18 9:42 PM, João Távora wrote: > Petko Bordjukov writes: > >> Emacs 26.1 enables flymake-rubocop by default if the rubocop executable >> is present in the system. Since most if not all of the warnings that >> Rubocop generates are not raised by Ruby I consider them not adopted by >> the Ruby community by default. Based on that, I propose that either >> using Rubocop by default is turned off, or at least a more inteligent >> per-project Rubocop detection scheme is implemented. >> > Paging Dmitry :-) So... First of all, there is the variable ruby-flymake-use-rubocop-if-available, to satisfy the individual preference to turn Rubocop off. Second, what kind of per-project detection scheme? I suppose we can abort if no ruby-rubocop-config file is found. That would certainly work for me, but would maybe conflict with the general usage of Rubocop out there (but probably not). Maybe Bozhidar has something to say on this?