From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: recent commit broke src/dired.c on OSX Date: Mon, 26 Jul 2010 19:58:50 +0300 Message-ID: <83d3uab2np.fsf@gnu.org> References: <86iq4379w0.fsf@red.stonehenge.com> <86eier7942.fsf@red.stonehenge.com> <86aapf78af.fsf@red.stonehenge.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1280163542 14536 80.91.229.12 (26 Jul 2010 16:59:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 26 Jul 2010 16:59:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chad Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 26 18:58:59 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OdR0z-0007E9-6n for ged-emacs-devel@m.gmane.org; Mon, 26 Jul 2010 18:58:57 +0200 Original-Received: from localhost ([127.0.0.1]:39003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdR0y-0004Fx-RJ for ged-emacs-devel@m.gmane.org; Mon, 26 Jul 2010 12:58:56 -0400 Original-Received: from [140.186.70.92] (port=40078 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdR0u-0004Fs-8E for emacs-devel@gnu.org; Mon, 26 Jul 2010 12:58:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OdR0t-0002AJ-1d for emacs-devel@gnu.org; Mon, 26 Jul 2010 12:58:52 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:51527) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdR0s-0002A6-Q9 for emacs-devel@gnu.org; Mon, 26 Jul 2010 12:58:51 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L6600600CH2ID00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Mon, 26 Jul 2010 19:58:49 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.61.30]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L660065GCI0IF00@a-mtaout21.012.net.il>; Mon, 26 Jul 2010 19:58:49 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127836 Archived-At: > From: Chad Brown > Date: Sun, 25 Jul 2010 20:12:01 -0700 > > Here's a stab at implementing Jan's suggestion: testing for dirent.h in configure instead of dancing around SYSV_SYSTEM_DIR. The changes are pretty small, and I have signed papers already anyway. > > I did simplify a test that checked for MSDOS, and I have no way to test on that platform, so I would appreciate it if someone would check to make sure I did no harm. Thanks. Whenever you add a test to configure and src/config.in, you need to add a suitable edit to msdos/sed*.inp scripts. In this case, they should edit config.in to define HAVE_DIRENT_H, since evidently the MSDOS build has it. If you don't do that, the DOS build will break.